Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Elastic-Agent] Use default output by default #18091

Merged
merged 2 commits into from
Apr 29, 2020
Merged

[Elastic-Agent] Use default output by default #18091

merged 2 commits into from
Apr 29, 2020

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Apr 29, 2020 •
edited
Loading

What does this PR do?

Releases neccesity of having use_output specified with monitoring settings.
if not output is specified the one called default is used

Why is it important?

Default configurations does not state use output settings so this might be confusing

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas michalpristas added bug needs_backport PR is waiting to be backported to other branches. elastic-agent Ingest Management:alpha1 Group issues for ingest management alpha1 labels Apr 29, 2020
@michalpristas michalpristas self-assigned this Apr 29, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 29, 2020
@michalpristas michalpristas requested a review from ph April 29, 2020 13:21
@michalpristas michalpristas changed the title use default output by default [Elastic-Agent] Use default output by default Apr 29, 2020
ph
ph approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michalpristas michalpristas removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 29, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 29, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

@michalpristas michalpristas merged commit 2b8fd05 into elastic:master Apr 29, 2020
michalpristas added a commit to michalpristas/beats that referenced this pull request Apr 30, 2020
@michalpristas
[Elastic-Agent] Use default output by default (elastic#18091)
3bf0cb1 
[Elastic-Agent] Use default output by default (elastic#18091)
@michalpristas michalpristas mentioned this pull request Apr 30, 2020
Merged
6 tasks
michalpristas added a commit that referenced this pull request May 4, 2020
@michalpristas
Cherry-pick #18091 to 7.x: Use default output by default (#18119)
ea44456 
* [Elastic-Agent] Use default output by default (#18091)

[Elastic-Agent] Use default output by default (#18091)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ph ph ph approved these changes

Assignees

@michalpristas michalpristas

Labels
bug Ingest Management:alpha1 Group issues for ingest management alpha1 needs_backport PR is waiting to be backported to other branches.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalpristas @elasticmachine @ph