Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic-Agent] Use /tmp for default monitoring endpoint location for libbeat #18131

Merged
merged 3 commits into from
Apr 30, 2020

Conversation

michalpristas
Copy link
Contributor

What does this PR do?

This PR moves default location feeded to metricbeat for exposing metrics endpoint to /tmp/ to cope with #18118

This way only risk is the length of the output name which needs to be handled in a followup

Why is it important?

To enable running agent deeper in a filesystem

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 30, 2020
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @ruflin new default as we discussed via zoom.

Co-authored-by: Pier-Hugues Pellerin <phpellerin@gmail.com>
@michalpristas michalpristas changed the title [Elastic-Agent] Use tmp for default metricbeat endpoint location [Elastic-Agent] Use /tmp for default monitoring endpoint location for libbeat Apr 30, 2020
@michalpristas michalpristas merged commit e9e587b into elastic:master Apr 30, 2020
@andresrc andresrc removed the needs_team Indicates that the issue/PR needs a Team:* label label May 2, 2020
michalpristas added a commit to michalpristas/beats that referenced this pull request May 4, 2020
… libbeat (elastic#18131)

* default tmp socket

* changelog

* Update x-pack/elastic-agent/CHANGELOG.asciidoc

Co-authored-by: Pier-Hugues Pellerin <phpellerin@gmail.com>

Co-authored-by: Pier-Hugues Pellerin <phpellerin@gmail.com>
michalpristas added a commit that referenced this pull request May 4, 2020
…logs (#18120)

* [Elastic-Agent] Use data subfolder as default for process logs (#17960)

[Elastic-Agent] Use data subfolder as default for process logs (#17960)

* [Elastic-Agent] Use /tmp for default monitoring endpoint location for libbeat (#18131)

* default tmp socket

* changelog

* Update x-pack/elastic-agent/CHANGELOG.asciidoc

Co-authored-by: Pier-Hugues Pellerin <phpellerin@gmail.com>

Co-authored-by: Pier-Hugues Pellerin <phpellerin@gmail.com>

* Update CHANGELOG.asciidoc

* conflicts

* go.sum

Co-authored-by: Pier-Hugues Pellerin <phpellerin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Ingest Management:alpha1 Group issues for ingest management alpha1 review [zube]: In Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants