Disable tracer by default #18339
Merged
Disable tracer by default #18339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
ycombinator
reviewed
May 7, 2020
libbeat/cmd/instance/beat.go
Outdated
| // an APM Server running, making it opt-in | ||
| if os.Getenv("ELASTIC_APM_ACTIVE") == "" { | ||
| os.Setenv("ELASTIC_APM_ACTIVE", "false") | ||
| } |
There was a problem hiding this comment.
Nit: now that there are a couple of APM-related initialization statements here in the init() function, maybe move them into their own function like initRand()?
ycombinator
approved these changes
May 7, 2020
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
urso
approved these changes
May 7, 2020
jalvz
added a commit
to jalvz/beats
that referenced
this pull request
May 7, 2020
jalvz
added a commit
to jalvz/beats
that referenced
this pull request
May 7, 2020
jalvz
added a commit
that referenced
this pull request
May 11, 2020
jalvz
added a commit
that referenced
this pull request
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a follow up of #17938
I made a wrong assumption there: If there is no
ELASTIC_APM_ACTIVEenv var, then the tracer is active.This PR reverts that behaviour to make it opt-in, instead opt-out.
This needs backport to 7.x and 7.8
Why is it important?
Because otherwise users will be required to have an APM Server running locally on a minor upgrade.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Run any beat and check there are not outgoing connections to localhost:8200