-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Winlogbeat] Add support for FileDelete events (event id 23) to sysmon module #18340
Merged
andrewkroh
merged 1 commit into
elastic:master
from
marc-gr:winlogbeat-add_sysmon-v11_support
May 7, 2020
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Binary file added
BIN
+68 KB
x-pack/winlogbeat/module/sysmon/test/testdata/sysmon-11-filedelete.evtx
Binary file not shown.
74 changes: 74 additions & 0 deletions
74
x-pack/winlogbeat/module/sysmon/test/testdata/sysmon-11-filedelete.evtx.golden.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
[ | ||
{ | ||
"@timestamp": "2020-05-07T07:27:18.722Z", | ||
"event": { | ||
"code": 23, | ||
"kind": "event", | ||
"module": "sysmon", | ||
"provider": "Microsoft-Windows-Sysmon" | ||
}, | ||
"fields": { | ||
"event": { | ||
"category": [ | ||
"file" | ||
], | ||
"type": [ | ||
"deletion" | ||
] | ||
} | ||
}, | ||
"file": { | ||
"name": "C:\\Windows\\ServiceProfiles\\LocalService\\AppData\\Local\\lastalive0.dat" | ||
}, | ||
"hash": { | ||
"sha1": "115106f5b338c87ae6836d50dd890de3da296367" | ||
}, | ||
"host": { | ||
"name": "vagrant-2012-r2" | ||
}, | ||
"log": { | ||
"level": "information" | ||
}, | ||
"process": { | ||
"entity_id": "{42f11c3b-b2b6-5eb3-18ab-000000000000}", | ||
"executable": "C:\\Windows\\System32\\svchost.exe", | ||
"name": "svchost.exe", | ||
"pid": 776 | ||
}, | ||
"rule": { | ||
"name": "-" | ||
}, | ||
"sysmon": { | ||
"file": { | ||
"archived": true, | ||
"is_executable": false | ||
} | ||
}, | ||
"user": { | ||
"domain": "NT AUTHORITY", | ||
"name": "LOCAL SERVICE" | ||
}, | ||
"winlog": { | ||
"api": "wineventlog", | ||
"channel": "Microsoft-Windows-Sysmon/Operational", | ||
"computer_name": "vagrant-2012-r2", | ||
"event_id": 23, | ||
"process": { | ||
"pid": 664, | ||
"thread": { | ||
"id": 2360 | ||
} | ||
}, | ||
"provider_guid": "{5770385f-c22a-43e0-bf4c-06f5698ffbd9}", | ||
"provider_name": "Microsoft-Windows-Sysmon", | ||
"record_id": 11, | ||
"user": { | ||
"domain": "NT AUTHORITY", | ||
"identifier": "S-1-5-18", | ||
"name": "SYSTEM", | ||
"type": "Well Known Group" | ||
}, | ||
"version": 5 | ||
} | ||
} | ||
] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
process
namespace is "managed" by ECS. Ifarchived
andis_executable
are not part of ECS then we should not add them toprocess
.Either leave them as-is or copy them over to a
sysmon
namespace likesysmon.is_archived
. Then add an entry to this file for the field. https://github.com/elastic/beats/blob/master/x-pack/winlogbeat/module/sysmon/_meta/fields.yml The benefit of copying them is that we can set the correct data type. Leaving them inwinlog.event_data
means they will be akeyword
in Elasticsearch rather than boolean.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added them to
sysmon.file.archived
andsysmon.file.is_executable
👍