Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] Add dashboard for GCP loadbalancing metricset #18369

Merged
merged 19 commits into from
Jun 25, 2020
Merged

[Metricbeat] Add dashboard for GCP loadbalancing metricset #18369

merged 19 commits into from
Jun 25, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented May 7, 2020

What does this PR do?

This PR is to add dashboards for loadbalancing metricset.

Screenshots

metricbeat-googlecloud-load-balancing-https-overview

metricbeat-googlecloud-load-balancing-l3-overview

metricbeat-googlecloud-load-balancing-tcp-ssl-proxy-overview

I couldn't generate tcp-ssl-proxy load balancer data so the last dashboard is created based on mock data.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 7, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this May 7, 2020
@kaiyan-sheng kaiyan-sheng added in progress Pull request is currently in progress. Team:Platforms Label for the Integrations - Platforms team labels May 7, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@elasticmachine
Copy link
Collaborator

elasticmachine commented May 8, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 3020
Skipped 756
Total 3776

Steps errors

Expand to view the steps failures

  • Name: Report to Codecov
    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Result: FAILURE

    • Duration: 2 min 22 sec

    • Start Time: 2020-05-09T14:54:59.236+0000

    • log

@kaiyan-sheng kaiyan-sheng marked this pull request as ready for review May 8, 2020 19:02
@andresrc andresrc added [zube]: Inbox [zube]: In Progress and removed needs_team Indicates that the issue/PR needs a Team:* label [zube]: Inbox labels May 9, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 4, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #18369 updated]

  • Start Time: 2020-06-25T19:08:08.384+0000

  • Duration: 61 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 3941
Skipped 920
Total 4861

@kaiyan-sheng kaiyan-sheng added [zube]: In Review needs_backport PR is waiting to be backported to other branches. review and removed [zube]: In Progress in progress Pull request is currently in progress. labels Jun 5, 2020
@kaiyan-sheng kaiyan-sheng requested a review from sayden June 23, 2020 15:15
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me! My question is why the HTTPS Overview visualisations are not drawing the lines but just the dots. Is any special setting missing from these TSVBs?

@kaiyan-sheng
Copy link
Contributor Author

@ChrsMark Thanks for the review! HTTPS overview is showing dots instead of lines not because of TSVB, it's because the real data I collected from GCP is sparse and not every collection period, there is data points available 😞 If one day I got better data points, I will definitely update the screenshots 😄

@kaiyan-sheng kaiyan-sheng merged commit 5ba7026 into elastic:master Jun 25, 2020
@kaiyan-sheng kaiyan-sheng deleted the lb_gcp branch June 25, 2020 20:53
@kaiyan-sheng kaiyan-sheng added v7.9.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jun 26, 2020
kaiyan-sheng added a commit that referenced this pull request Jun 30, 2020
…19469)

* Add dashboard for GCP loadbalancing metricset
* add https load balancing dashboard
* add dashboard for tcp-ssl-proxy

(cherry picked from commit 5ba7026)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
…8369)

* Add dashboard for GCP loadbalancing metricset
* add https load balancing dashboard
* add dashboard for tcp-ssl-proxy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Platforms Label for the Integrations - Platforms team v7.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants