Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Improve ECS categorization field mappings in coredns module. #18424

Merged
merged 3 commits into from
May 15, 2020

Conversation

leehinman
Copy link
Contributor

What does this PR do?

Improves ECS categorization field mappings in coredns module.
Specifically:

  • event.kind
  • event.category
  • event.type
  • event.outcome
  • network.protocol
  • related.ip

Why is it important?

ECS categorization fields improve the usability of the data in the SIEM app and
improve cross correlation between data sources.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

TESTING_FILEBEAT_MODULES=coredns mage -v pythonIntegTest

Related issues

@leehinman leehinman added enhancement Filebeat Filebeat needs_backport PR is waiting to be backported to other branches. Team:SIEM ecs labels May 11, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 11, 2020
- event.kind
- event.category
- event.type
- event.outcome
- network.protocol
- related.ip

Closes elastic#16159
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 11, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 1187
Skipped 128
Total 1315

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andresrc andresrc removed the needs_team Indicates that the issue/PR needs a Team:* label label May 12, 2020
@leehinman leehinman merged commit 1ece3b6 into elastic:master May 15, 2020
@leehinman leehinman deleted the 16159_coredns_ecs_1.4 branch May 15, 2020 14:52
@leehinman leehinman added v7.9.0 and removed needs_backport PR is waiting to be backported to other branches. labels May 15, 2020
leehinman added a commit to leehinman/beats that referenced this pull request May 15, 2020
…e. (elastic#18424)

* Improve ECS categorization field mappings in coredns module.

- event.kind
- event.category
- event.type
- event.outcome
- network.protocol
- related.ip
- explicitly set ECS version

Closes elastic#16159

(cherry picked from commit 1ece3b6)
leehinman added a commit that referenced this pull request May 18, 2020
…e. (#18424) (#18586)

* Improve ECS categorization field mappings in coredns module.

- event.kind
- event.category
- event.type
- event.outcome
- network.protocol
- related.ip
- explicitly set ECS version

Closes #16159

(cherry picked from commit 1ece3b6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Filebeat] Upgrade coredns module to ECS 1.4
4 participants