Don't set dns.resolved_ip with invalid IP addresses #18436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
added
bug
Winlogbeat
needs_backport
botelastic
bot
added
the
needs_team
Sometimes the DNS IP addresses from Sysmon in `winlog.event_data.QueryResults` are truncated. The leads to mapping exceptions since the value is not of type `ip` in Elasticsearch. To fix this the module will now filter any results that are not valid IP addresses. Fixes elastic#18432
andrewkroh
force-pushed
the
bugfix/wlb/sysmon-dns-truncated
branch
from
1c266e4
to
7b31d06
Compare
|
Pinging @elastic/siem (Team:SIEM) |
andrewkroh
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
marc-gr
approved these changes
May 12, 2020
3 tasks
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
May 12, 2020
Sometimes the DNS IP addresses from Sysmon in `winlog.event_data.QueryResults` are truncated. The leads to mapping exceptions since the value is not of type `ip` in Elasticsearch. To fix this the module will now filter any results that are not valid IP addresses. Fixes elastic#18432 (cherry picked from commit ecd0f72)
andrewkroh
added
v7.9.0
and removed
needs_backport
3 tasks
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
May 12, 2020
Sometimes the DNS IP addresses from Sysmon in `winlog.event_data.QueryResults` are truncated. The leads to mapping exceptions since the value is not of type `ip` in Elasticsearch. To fix this the module will now filter any results that are not valid IP addresses. Fixes elastic#18432 (cherry picked from commit ecd0f72)
andrewkroh
added a commit
that referenced
this pull request
May 13, 2020
Sometimes the DNS IP addresses from Sysmon in `winlog.event_data.QueryResults` are truncated. The leads to mapping exceptions since the value is not of type `ip` in Elasticsearch. To fix this the module will now filter any results that are not valid IP addresses. Fixes #18432 (cherry picked from commit ecd0f72)
andrewkroh
added a commit
that referenced
this pull request
May 13, 2020
Sometimes the DNS IP addresses from Sysmon in `winlog.event_data.QueryResults` are truncated. The leads to mapping exceptions since the value is not of type `ip` in Elasticsearch. To fix this the module will now filter any results that are not valid IP addresses. Fixes #18432 (cherry picked from commit ecd0f72)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sometimes the DNS IP addresses from Sysmon in
winlog.event_data.QueryResultsare truncated.The leads to mapping exceptions since the value is not of type
ipin Elasticsearch.To fix this the module will now filter any results that are not valid IP addresses.
Why is it important?
The issue causes mapping exceptions that could lead to dropped events.
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Fixes #18432