Cherry-pick #18317 to 7.x: [CI] cancel old builds #18452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
v1v
changed the title
v1v
added
backport
Team:Automation
kuisathaverat
approved these changes
May 12, 2020
❕ Build Aborted
Expand to view the summary
Build stats
Test stats 🧪
Log outputExpand to view the last 100 lines of log output
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x:
Original message:
What does this PR do?
Enable cancel old builds. If enabled then the GitHub PR comments will notify the build has been aborted (there is an open issue to disable the notifications for this particular case)
Why is it important?
Avoid wasting build cycles for old commits
How to test this PR locally
We can comment
Jenkins run the tests pleasea few times to validate it works as expectedBuild number 3 was caused with the comment: #18317 (comment) and number 4 with the comment: #18317 (comment)
Use cases
Sequential builds mean slow feedback while concurrent builds mean faster feedback but as a downside it means more resources, aka money. So this will help to align the quick feedback with less resources.
On the other hand, we will be working on the GitHub PR comments to avoid any kind of feedback if the build got aborted.
Questions
They run as a specific post-cleanup stage:
beats/Jenkinsfile
Lines 384 to 388 in 8f16020
Tasks
ABORTEDandUNSTABLE. NOTE: we are working on levelling the build status report with something like:Expand to view screenshots