Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #18317 to 7.8: [CI] cancel old builds #18453

Merged
merged 1 commit into from
May 13, 2020

Conversation

v1v
Copy link
Member

@v1v v1v commented May 12, 2020

Backports the following commits to 7.8:

Original message:

What does this PR do?

Enable cancel old builds. If enabled then the GitHub PR comments will notify the build has been aborted (there is an open issue to disable the notifications for this particular case)

Why is it important?

Avoid wasting build cycles for old commits

How to test this PR locally

We can comment Jenkins run the tests please a few times to validate it works as expected

Build number 3 was caused with the comment: #18317 (comment) and number 4 with the comment: #18317 (comment)

image

image

Use cases

Sequential builds mean slow feedback while concurrent builds mean faster feedback but as a downside it means more resources, aka money. So this will help to align the quick feedback with less resources.

On the other hand, we will be working on the GitHub PR comments to avoid any kind of feedback if the build got aborted.

Questions

  • How to delete the cloud scenarios that have been created?

image

They run as a specific post-cleanup stage:

  • beats/Jenkinsfile

    Lines 384 to 388 in 8f16020

    post {
    cleanup {
    terraformCleanup('x-pack-metricbeat', 'x-pack/metricbeat')
    }
    }

Tasks

  • Categorise build status for ABORTED and UNSTABLE. NOTE: we are working on levelling the build status report with something like:
Expand to view screenshots

image

image

image

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 12, 2020
@v1v v1v changed the title [7.8] [CI] cancel old builds (#18317) Cherry-pick #18317 to 7.8: [CI] cancel old builds May 12, 2020
@v1v v1v requested a review from kuisathaverat May 12, 2020 14:24
@v1v v1v self-assigned this May 12, 2020
@v1v v1v added backport Team:Automation Label for the Observability productivity team and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 12, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 5886
Skipped 899
Total 6785

@v1v v1v merged commit cf2481d into elastic:7.8 May 13, 2020
@v1v v1v deleted the backport/7.8/pr-18317 branch May 13, 2020 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants