-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat] Fix tags_filter for cloudwatch metricset in aws module #18524
Conversation
Pinging @elastic/integrations-platforms (Team:Platforms) |
💚 Build SucceededExpand to view the summary
Build stats
Test stats 🧪
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codewise lgtm!
Wondering if we should document this behaviour in the docs 🤔 .
…oudwatch metricset in aws module (elastic#18618) * [Metricbeat] Fix tags_filter for cloudwatch metricset in aws module (elastic#18524) * Fix tags_filter for cloudwatch metricset * if tags_filter is given, overwrite tags in cloudwatch specific config (cherry picked from commit 0d56bc8)
What does this PR do?
This PR is to fix
tags_filter
for cloudwatch metricset. Without this fix, when user tries to specifytags_filter
in aws module config, it does not apply the filter on what events to send to ES.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.