Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libbeat] Remove global loggers from plugin and mock #18552

Merged
merged 6 commits into from
Jun 15, 2020
Merged

[libbeat] Remove global loggers from plugin and mock #18552

merged 6 commits into from
Jun 15, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented May 14, 2020

This PR is to remove global loggers for libbeat/plugin/cli.
Please see #15699 for the meta-issue and more details.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 14, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this May 14, 2020
@kaiyan-sheng kaiyan-sheng added needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@kaiyan-sheng kaiyan-sheng changed the title [libbeat] Remove global loggers from plugin/cli [libbeat] Remove global loggers from plugin and mock May 14, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 14, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 9214
Skipped 1542
Total 10756

Copy link
Contributor

@fearful-symmetry fearful-symmetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure we're trying to have the logger name match the literal go library they're in. Try logp.NewLogger("mock") and so on.

@kaiyan-sheng
Copy link
Contributor Author

@fearful-symmetry Thanks! Good to know, I just changed the logger name to mock.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #18552 updated]

  • Start Time: 2020-05-26T17:33:46.411+0000

  • Duration: 71 min 3 sec

Test stats 🧪

Test Results
Failed 0
Passed 9246
Skipped 1542
Total 10788

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 2, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #18552 updated]

  • Start Time: 2020-06-03T17:51:10.314+0000

  • Duration: 84 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 9305
Skipped 1574
Total 10879

Steps errors

Expand to view the steps failures

  • Name: Report to Codecov
    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Duration: 2 min 22 sec

    • Start Time: 2020-06-03T18:17:56.646+0000

    • log

@kaiyan-sheng kaiyan-sheng requested a review from urso June 15, 2020 14:23
@kaiyan-sheng kaiyan-sheng added v7.9.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jun 15, 2020
kaiyan-sheng added a commit that referenced this pull request Jun 16, 2020
* [libbeat] Remove global loggers from plugin/cli

(cherry picked from commit 9a1b1d0)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
* [libbeat] Remove global loggers from plugin/cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Integrations Label for the Integrations team v7.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants