Introduce mode: stack-monitoring for Metricbeat stack modules #18610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
This issue doesn't have a |
❕ Build Aborted
Expand to view the summary
Build stats
Log outputExpand to view the last 100 lines of log output
|
ycombinator
force-pushed
the
mb-stack-deprecate-xpack-enabled
branch
from
0290952
to
2ae9beb
Compare
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
ycombinator
force-pushed
the
mb-stack-deprecate-xpack-enabled
branch
from
cf2ece5
to
f65b834
Compare
ycombinator
commented
May 19, 2020
| @@ -65,11 +65,30 @@ func TestGetVertexClusterUUID(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestXPackEnabledMetricSets(t *testing.T) { | |||
| func TestXPackEnabledMetricsets(t *testing.T) { | |||
There was a problem hiding this comment.
Just making this consistent with other stack modules' tests.
ycombinator
commented
May 19, 2020
| base, | ||
| http, | ||
| config.GetMode() == elastic.ModeStackMonitoring, | ||
| }, nil | ||
| } |
There was a problem hiding this comment.
I have no idea why GitHub thinks this is a rename! I deleted the file on the left completely and created the file on the right completely from scrath.
ycombinator
added
[zube]: In Review
needs_backport
|
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
removed
the
needs_team
zube
bot
added
[zube]: Inbox
needs_team
|
Pinging @elastic/stack-monitoring (Stack monitoring) |
botelastic
bot
removed
the
needs_team
|
This pull request doesn't have a |
zube
bot
added
[zube]: Inbox
[zube]: In Review
and removed
Feature:Stack Monitoring
[zube]: In Review
[zube]: Inbox
labels
ycombinator
force-pushed
the
mb-stack-deprecate-xpack-enabled
branch
from
4332971
to
16a503e
Compare
andresrc
added
[zube]: Inbox
[zube]: In Review
and removed
[zube]: In Review
[zube]: Inbox
labels
|
We're not sure if the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduces a new
modesetting for Metricbeat Elastic Stack modules. The valid values for this setting aredefaultorstack-monitoring. This setting replaces the oldxpack.enabledsetting, which is still available but deprecated after this PR.Users should convert from using the deprecated setting to the new setting as shown below.
xpack.enabled: false(default value)mode: default(default value)xpack.enabled: truemode: stack-monitoringCorresponding to the setting change / deprecation, users should also use the new module configuration variant name as shown below.
metricbeat modules enable elasticsearch-xpackmetricbeat modules enable elasticsearch-stack-monitoringmetricbeat modules disable elasticsearch-xpackmetricbeat modules disable elasticsearch-stack-monitoringmetricbeat modules enable kibana-xpackmetricbeat modules enable kibana-stack-monitoringmetricbeat modules disable kibana-xpackmetricbeat modules disable kibana-stack-monitoringmetricbeat modules enable logstash-xpackmetricbeat modules enable logstash-stack-monitoringmetricbeat modules disable logstash-xpackmetricbeat modules disable logstash-stack-monitoringmetricbeat modules enable beat-xpackmetricbeat modules enable beat-stack-monitoringmetricbeat modules disable beat-xpackmetricbeat modules disable beat-stack-monitoringWhy is it important?
A couple of reasons:
xpackin as many places as possible, andxpack.enabled) and module configuration variant suffix (-xpack) are not very descriptive of their purpose.What does this PR NOT do?
As mentioned above, one of the motivations for the
modesetting is to get rid of the termxpack. This term is still used in code in identifiers. This PR does not update those uses. That will be done in a follow up PR, mainly to keep the scope and size of this PR small.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues