Validate config before init NewInput to avoid uneccessory cleanup and kubernetes watcher leak #18630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
botelastic
bot
added
the
needs_team
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
|
@exekias Hi, PTAL |
|
Thank you so much for contributing @DanielQujun! This is looking good to me, pinging @urso just in case you see something I miss |
exekias
approved these changes
May 20, 2020
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
removed
the
needs_team
|
@DanielQujun could you please add a new line to the |
DanielQujun
force-pushed
the
validate_input_config_before_init
branch
2 times, most recently
from
e8aee9d
to
3bd083c
Compare
thanks for your review, updated done. |
|
@urso Hi, would you please take a look at your convenience. |
urso
approved these changes
May 27, 2020
|
jenkins run tests |
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
…t's misconfigured(elastic#18629) fix log format missing in libbeat/common/kubernetes/util.go Signed-off-by: 屈骏 <qujun@tiduyun.com>
DanielQujun
force-pushed
the
validate_input_config_before_init
branch
from
3bd083c
to
a93628b
Compare
|
@exekias Hi, I have rebased with master branch, Do I get a flaky test? |
exekias
added
the
needs_backport
|
It seems the test was unrelated Thank you for contributing!! 🎉 |
exekias
pushed a commit
to exekias/beats
that referenced
this pull request
May 28, 2020
…t's misconfigured(elastic#18629) (elastic#18630) fix log format missing in libbeat/common/kubernetes/util.go Signed-off-by: 屈骏 <qujun@tiduyun.com> (cherry picked from commit 74d81c2)
exekias
added
v7.9.0
and removed
needs_backport
exekias
pushed a commit
that referenced
this pull request
May 28, 2020
|
Great! Thanks~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative Fix #18629
When Filebeat using
add_kubernetes_metadataprocessor and enabledinput.reload, It will cause Kubernetes watcher goroutine leaks when the input config is wrong.I looked through the code in
filebeat/input/log/input.go, notice that there is a defer function to cleanup when executingNewInputfailed.beats/filebeat/input/log/input.go
Line 76 in d11d609
But it seems not easy to add Kubernetes watcher stopping function here, So I move the validate section to the top, then
NewInputwill return directly if the config not qualified.