-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get stats for all indices, including hidden indices #18703
Conversation
💔 Tests FailedExpand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
Pinging @elastic/stack-monitoring (Stack monitoring) |
Pinging @elastic/integrations-services (Team:Services) |
378545c
to
3b52f14
Compare
💔 Tests FailedExpand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
3b52f14
to
4e334a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added a question about getting stats now for closed indices too, I guess we are ok with that, but just in case. Maybe we need to mention closed indices also in the changelog.
459e86a
to
81eab48
Compare
@jsoriano I've addressed your review feedback regarding closed indices. This PR is ready for re-review, when you get a chance. Thanks! |
CI failures are unrelated. Merging. |
* Get stats for all indices * Update default stack versions to use in integration tests * Add integration test for hidden indices stats * Better naming of variables * Adding CHANGELOG entry * Use expand_wildcards in tests as well * Collect stats for open and hidden indices (but not closed ones)
* Get stats for all indices * Update default stack versions to use in integration tests * Add integration test for hidden indices stats * Better naming of variables * Adding CHANGELOG entry * Use expand_wildcards in tests as well * Collect stats for open and hidden indices (but not closed ones)
What does this PR do?
elasticsearch/index
metricset to collect metrics for all indices, including hidden ones.Why is it important?
With the introduction of hidden indices in Elasticsearch (elastic/elasticsearch#50452), the
GET _stats
API call, by default, does not return stats for hidden indices. So it needs to be enhanced to request stats for all indices.Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues