Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Winlogbeat] Fix issue with missing module fields in index template #18983

Merged

Conversation

andrewkroh
Copy link
Member

What does this PR do?

The fields.go files were not being imported for the Winlogbeat modules so they were absent from the index template.

Why is it important?

To avoid dynamic mappings for fields that we already defined in fields.yml.

@andrewkroh andrewkroh added bug Winlogbeat Team:SIEM x-pack Issues and pull requests for X-Pack features. labels Jun 4, 2020
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 4, 2020
The fields.go files were not being imported for the Winlogbeat modules so they were absent from the index template.
@andrewkroh andrewkroh force-pushed the bugfix/wlb/import-xpack-fields branch from 2dc4a91 to 147cbdf Compare June 4, 2020 19:08
@andrewkroh andrewkroh marked this pull request as ready for review June 4, 2020 19:08
@andrewkroh andrewkroh requested a review from a team as a code owner June 4, 2020 19:08
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 4, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #18983 updated]

  • Start Time: 2020-06-04T19:09:10.145+0000

  • Duration: 38 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 598
Skipped 127
Total 725

@andrewkroh andrewkroh merged commit 82dc7c0 into elastic:master Jun 5, 2020
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
The fields.go files were not being imported for the Winlogbeat modules so they were absent from the index template.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Winlogbeat x-pack Issues and pull requests for X-Pack features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants