-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat] Update Couchbase module to 6.5 version #19055
[Metricbeat] Update Couchbase module to 6.5 version #19055
Conversation
Pinging @elastic/integrations-services (Team:Services) |
💔 Tests FailedExpand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good, added some suggestions about compatibility notes, changelog and tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but failures in tests seem to be related.
91d5cb6
to
4d66925
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couchbase tests passed in CI, failure (on redis test) doesn't seem related.
(cherry picked from commit c7f9937)
(cherry picked from commit c7f9937)
(cherry picked from commit c7f9937) # Conflicts: # metricbeat/docs/fields.asciidoc # metricbeat/module/couchbase/_meta/Dockerfile # metricbeat/module/couchbase/_meta/docs.asciidoc # metricbeat/module/couchbase/docker-compose.yml # metricbeat/module/couchbase/fields.go # metricbeat/module/couchbase/test_couchbase.py
What does this PR do?
Changes the number format of some fields that seems to be returned in floating point while we expect them like integers.
It seems that some of the values returned by Couchbase are in floating point numbers. In fact, all the data is returned in JSON format so every single number might be a floating point number.
Checklist
[ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Just execute the module normally. Unfortunately, the bug can't be reproduce easily (or at all)
Related issues
Fixes: #18949
Fixes: #18595