Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #18892 to 7.x: [Filebeat] Adds oauth2 support for httpjson input #19122

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Jun 11, 2020

Cherry-pick of PR #18892 to 7.x branch. Original message:

What does this PR do?

Adds oauth2 support to filebeat HTTPJSON input.

Why is it important?

This will let us pull data from oauth2 authenticated sources, like AzureAD or GSuite.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Closes #18415

@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 11, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 11, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19122 updated]

  • Start Time: 2020-06-16T10:13:40.954+0000

  • Duration: 75 min 41 sec

Test stats 🧪

Test Results
Failed 0
Passed 6778
Skipped 1069
Total 7847

@marc-gr marc-gr requested a review from a team June 15, 2020 10:06
…18892)

* Filebeat HTTPJSON input initial changes to support oauth2 client_credentials

* [Filebeat][httpjson] Add EndpointParams option to oauth config

* Add provider specific settings to oauth httpjson

* Change config as suggested and add config tests

* Add checks for invalid json in google validation

* Add documentation and azure.resource

* Add oauth2 test and update changelog

* Address docs and change new test case into table tests

* Check if oauth2 is enabled in config.Validate and add test

Closes elastic#18415

(cherry picked from commit b6cd17c)
@marc-gr marc-gr merged commit 49d511d into elastic:7.x Jun 16, 2020
@marc-gr marc-gr deleted the backport_18892_7.x branch June 16, 2020 11:35
@zube zube bot removed the [zube]: Done label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants