-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ingest Manager] New structure of agent configuration #19128
Changes from 1 commit
4e79b49
a044e9c
3f2e35e
94741ed
bd8f87c
e8b58ba
c57a694
85ad9c5
299bf28
903bc2e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -369,7 +369,7 @@ func (r *FixStreamRule) Apply(ast *AST) error { | |
} | ||
|
||
for _, inputNode := range inputsNodeList.value { | ||
nsNode, found := inputNode.Find("namespace") | ||
nsNode, found := inputNode.Find("dataset.namespace") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no in fact it will not, i added support for both just to be sure |
||
if found { | ||
nsKey, ok := nsNode.(*Key) | ||
if ok { | ||
|
@@ -383,7 +383,7 @@ func (r *FixStreamRule) Apply(ast *AST) error { | |
continue | ||
} | ||
datasourceMap.value = append(datasourceMap.value, &Key{ | ||
name: "namespace", | ||
name: "dataset.namespace", | ||
value: &StrVal{value: defaultNamespace}, | ||
}) | ||
} | ||
|
@@ -404,7 +404,7 @@ func (r *FixStreamRule) Apply(ast *AST) error { | |
continue | ||
} | ||
|
||
dsNode, found := streamNode.Find("dataset") | ||
dsNode, found := streamNode.Find("dataset.name") | ||
if found { | ||
dsKey, ok := dsNode.(*Key) | ||
if ok { | ||
|
@@ -414,7 +414,7 @@ func (r *FixStreamRule) Apply(ast *AST) error { | |
} | ||
} else { | ||
streamMap.value = append(streamMap.value, &Key{ | ||
name: "dataset", | ||
name: "dataset.name", | ||
value: &StrVal{value: defaultDataset}, | ||
}) | ||
} | ||
|
@@ -455,7 +455,7 @@ func (r *InjectIndexRule) Apply(ast *AST) error { | |
|
||
for _, inputNode := range inputsList.value { | ||
namespace := defaultNamespace | ||
nsNode, found := inputNode.Find("namespace") | ||
nsNode, found := inputNode.Find("dataset.namespace") | ||
if found { | ||
nsKey, ok := nsNode.(*Key) | ||
if ok { | ||
|
@@ -483,7 +483,7 @@ func (r *InjectIndexRule) Apply(ast *AST) error { | |
|
||
dataset := defaultDataset | ||
|
||
dsNode, found := streamNode.Find("dataset") | ||
dsNode, found := streamNode.Find("dataset.name") | ||
if found { | ||
dsKey, ok := dsNode.(*Key) | ||
if ok { | ||
|
@@ -535,7 +535,7 @@ func (r *InjectStreamProcessorRule) Apply(ast *AST) error { | |
|
||
for _, inputNode := range inputsList.value { | ||
namespace := defaultNamespace | ||
nsNode, found := inputNode.Find("namespace") | ||
nsNode, found := inputNode.Find("dataset.namespace") | ||
if found { | ||
nsKey, ok := nsNode.(*Key) | ||
if ok { | ||
|
@@ -563,7 +563,7 @@ func (r *InjectStreamProcessorRule) Apply(ast *AST) error { | |
|
||
dataset := defaultDataset | ||
|
||
dsNode, found := streamNode.Find("dataset") | ||
dsNode, found := streamNode.Find("dataset.name") | ||
if found { | ||
dsKey, ok := dsNode.(*Key) | ||
if ok { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably good to add one of these tests files to use:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mean with invalid key?
keys we dont know are passed to input by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I mean add a test to ensure that
dataset.namespace: testing
orBoth work