Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #19131 to 7.x: [filebeat][netflow] Support up to 7 bytepad for Netflow IPFIX template #19191

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Jun 15, 2020

Cherry-pick of PR #19131 to 7.x branch. Original message:

What does this PR do?

Fixes netflow v9 decoder to support up to 7 bytes of padding for IPFIX templates.

Why is it important?

Previously was failing to process packets with more than 3 bytes of padding.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Fixes #18098

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 15, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 15, 2020
@marc-gr marc-gr requested a review from a team June 15, 2020 10:13
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19191 opened]

  • Start Time: 2020-06-15T10:13:26.181+0000

  • Duration: 50 min 34 sec

Test stats 🧪

Test Results
Failed 0
Passed 1722
Skipped 255
Total 1977

Steps errors

Expand to view the steps failures

  • Name: Report to Codecov
    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Duration: 2 min 22 sec

    • Start Time: 2020-06-15T11:00:12.410+0000

    • log

@marc-gr marc-gr merged commit 8e8a7a2 into elastic:7.x Jun 15, 2020
@marc-gr marc-gr deleted the backport_19131_7.x branch June 15, 2020 12:58
@zube zube bot removed the [zube]: Done label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants