-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for cloudfoundry metrics collection using consumer v1 API #19268
Merged
jsoriano
merged 11 commits into
elastic:master
from
jsoriano:cloudfoundry-metricbeat-v1
Jun 24, 2020
Merged
Add support for cloudfoundry metrics collection using consumer v1 API #19268
jsoriano
merged 11 commits into
elastic:master
from
jsoriano:cloudfoundry-metricbeat-v1
Jun 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Jun 18, 2020
jsoriano
added
[zube]: In Progress
in progress
Pull request is currently in progress.
Team:Platforms
Label for the Integrations - Platforms team
labels
Jun 18, 2020
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Jun 18, 2020
zube
bot
added
[zube]: Inbox
[zube]: In Progress
and removed
[zube]: In Progress
[zube]: Inbox
labels
Jun 18, 2020
zube
bot
added
[zube]: Inbox
[zube]: In Progress
and removed
[zube]: In Progress
[zube]: Inbox
labels
Jun 18, 2020
zube
bot
added
[zube]: Inbox
[zube]: In Progress
and removed
[zube]: Inbox
[zube]: In Progress
labels
Jun 18, 2020
Pinging @elastic/integrations-platforms (Team:Platforms) |
jsoriano
added
needs_backport
PR is waiting to be backported to other branches.
v7.9.0
labels
Jun 23, 2020
18 tasks
exekias
approved these changes
Jun 24, 2020
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Jun 24, 2020
…elastic#19268) As previously done for the Filebeat input, add support for metrics collection in the Metricbeat module using the consumer v1 API. It reuses the same Doppler consumer used in Filebeat. v2 API is still supported, and can be selected by adding `version: v2` to the configuration, v1 is used by default as is in principle more reliable. (cherry picked from commit 5645491)
6 tasks
jsoriano
removed
the
needs_backport
PR is waiting to be backported to other branches.
label
Jun 24, 2020
jsoriano
added a commit
that referenced
this pull request
Jun 25, 2020
…#19268) (#19372) As previously done for the Filebeat input, add support for metrics collection in the Metricbeat module using the consumer v1 API. It reuses the same Doppler consumer used in Filebeat. v2 API is still supported, and can be selected by adding `version: v2` to the configuration, v1 is used by default as is in principle more reliable. (cherry picked from commit 5645491)
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
…elastic#19268) As previously done for the Filebeat input, add support for metrics collection in the Metricbeat module using the consumer v1 API. It reuses the same Doppler consumer used in Filebeat. v2 API is still supported, and can be selected by adding `version: v2` to the configuration, v1 is used by default as is in principle more reliable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
in progress
Pull request is currently in progress.
Team:Platforms
Label for the Integrations - Platforms team
v7.9.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Continues with #19125 to add support to Cloud Foundry consumer v1 API in Metricbeat too.
version
can be used to select ifv1
orv2
version should be used.Why is it important?
We already support the v2 API, but we saw that this API is not reliable enough (see #18202 and #18282).
Checklist
I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
version
option:version
option (what would usev1
)version: v1
.version: v2
.version
it should fail to start.Related issues