Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #19128 to 7.x: New structure of agent configuration #19270

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Cherry-pick #19128 to 7.x: New structure of agent configuration #19270

merged 1 commit into from
Jun 24, 2020

Conversation

michalpristas
Copy link
Contributor

Cherry-pick of PR #19128 to 7.x branch. Original message:

What does this PR do?

This PR implements all 4 phases of configuration change described here #19082

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas
[Ingest Manager] New structure of agent configuration (elastic#19128)
bbb105d 
* phase 1

* phase 2

* phase 4

* updated configuration

* fixed compact form (depends on aprser)

* configuration update

* fixed tests

* mod
@michalpristas michalpristas self-assigned this Jun 18, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 18, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 18, 2020
@michalpristas michalpristas requested a review from ruflin June 18, 2020 12:45
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 18, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Branch indexing]

  • Start Time: 2020-06-18T15:13:56.303+0000

  • Duration: 82 min 0 sec

blakerouse
blakerouse approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

ruflin
ruflin approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Make sure to merge in sync with @jen-huang

@jen-huang
Copy link

The corresponding Kibana change has already been backported to 7.x.

@michalpristas michalpristas merged commit d5da517 into elastic:7.x Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

@ruflin ruflin ruflin approved these changes

Assignees

@michalpristas michalpristas

Labels
backport Ingest Management:beta1 Group issues for ingest management beta1 review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@michalpristas @elasticmachine @jen-huang @ruflin @blakerouse