Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #19167 to 7.x: [Packetbeat] ECS 1.5 update #19288

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

andrewstucki
Copy link

@andrewstucki andrewstucki commented Jun 18, 2020

Cherry-pick of PR #19167 to 7.x branch. Original message:

What does this PR do?

Updates packetbeat to use ECS categorization and related.ip fields. Also, readies the TLS protocol parser to use the new x509 fields coming in 1.6.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

* Add packetbeat changes

* Fix up tests

* Add changelog entry

* Add compile time upgrade guard as a reminder and add inline marshal tag for ecs

* Fix early termination for marshaling code

(cherry picked from commit 9e9aa88)
@andrewstucki andrewstucki requested a review from a team as a code owner June 18, 2020 18:24
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 18, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 18, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19288 opened]

  • Start Time: 2020-06-18T18:27:10.756+0000

  • Duration: 77 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 718
Skipped 128
Total 846

Steps errors

Expand to view the steps failures

  • Name: Report to Codecov
    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Duration: 2 min 22 sec

    • Start Time: 2020-06-18T19:10:48.465+0000

    • log

@andrewstucki andrewstucki merged commit 6ee18b2 into elastic:7.x Jun 18, 2020
@andrewstucki andrewstucki deleted the backport_19167_7.x branch June 18, 2020 21:20
@zube zube bot removed the [zube]: Done label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants