Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #18534 to 7.8: Address Okta input issue #18530 #19468

Merged
merged 2 commits into from
Jun 29, 2020
Merged

Cherry-pick #18534 to 7.8: Address Okta input issue #18530 #19468

merged 2 commits into from
Jun 29, 2020

Conversation

alakahakai
Copy link

Backport PR #18534 to 7.8

* Add check for time because time.Until does not correctly handle a time that is earlier than time.Now().

* Update getRateLimit to handle a rate limit time is earlier than now.

* Add some additional safe guard to check Ticker

* Add descriptions for getRateLimit function and test functions.

* Update CHANGELOG.next.asciidoc

(cherry picked from commit db62862)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 26, 2020
@alakahakai alakahakai changed the title Address Okta input issue #18530 (#18534) Cherry-pick #18534 to 7.8: Address Okta input issue #18530 Jun 26, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 26, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 26, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19468 updated]

  • Start Time: 2020-06-26T22:53:52.092+0000

  • Duration: 52 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 2194
Skipped 382
Total 2576

@alakahakai
Copy link
Author

@andrewkroh Please take a look at this again. Thanks

@alakahakai alakahakai merged commit f4065b5 into elastic:7.8 Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants