tlscommon: require cert in ServerConfig.Validate #19584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does not make sense to configure server-side TLS without specifying a certificate and key pair. Check that both a certificate and key are configured. We were previously checking that both or neither were specified.
botelastic
bot
added
the
needs_team
❕ Build Aborted
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
andresrc
added
the
Team:Services
|
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
removed
the
needs_team
urso
approved these changes
Jul 2, 2020
|
jenkins run the tests please |
|
Checking the last CI output relevant tests did look ok. One flaky test failed, and there have been a few network timeouts when publishing results. |
|
@axw Can you please backport this to 7.x? Thanks! |
4 tasks
axw
added
v7.9.0
and removed
needs_backport
axw
added a commit
to axw/beats
that referenced
this pull request
Jul 7, 2020
* tlscommon: require cert in ServerConfig.Validate It does not make sense to configure server-side TLS without specifying a certificate and key pair. Check that both a certificate and key are configured. We were previously checking that both or neither were specified. (cherry picked from commit c63cd32)
urso
pushed a commit
that referenced
this pull request
Jul 7, 2020
2 tasks
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
* tlscommon: require cert in ServerConfig.Validate It does not make sense to configure server-side TLS without specifying a certificate and key pair. Check that both a certificate and key are configured. We were previously checking that both or neither were specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When validating server-side TLS config, ensure there is a certificate and key pair.
Why is it important?
It does not make sense to configure server-side TLS without specifying a certificate and key pair. If users enable TLS (
ssl.enabled) for a server (e.g. APM Server) but do not specify a certificate or key file, then they should receive a helpful error message indicating that the configuration is missing.Checklist
- [ ] I have made corresponding changes to the documentation(The metricbeat docs talk about client cert/key only; the APM Server docs already state that these config fields are required.)- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
It should exit with an error containing the phrase "certificate file not configured".
Related issues
elastic/apm-server#3908