Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update filebeat registrar to use statestore #19633

Merged
merged 5 commits into from
Jul 6, 2020
Merged

Update filebeat registrar to use statestore #19633

merged 5 commits into from
Jul 6, 2020

Conversation

urso
Copy link

@urso urso commented Jul 3, 2020 •
edited by andresrc
Loading

  • Refactoring

What does this PR do?

Update filebeat registrar, initialization and testing to use the
statestore as new persistent storage backend between restarts.

This PR swaps out the storage backend, adds support for migrating old registry files to the statestore, and updates existing tests in filebeat. The migration support extends the already existing migration support, supporting old registry files from the 6.x release as well (system tests start at 6.3).

Why is it important?

  • Provide support for seamless migration to new storage format
  • By using the same store old and new style inputs can coexist more easily.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Run filebeat tests/system

Related issues

@urso urso added review Filebeat Filebeat needs_backport PR is waiting to be backported to other branches. [zube]: In Review Project:Filebeat-Input-v2 Team:Services (Deprecated) Label for the former Integrations-Services team v7.9.0 labels Jul 3, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 3, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 3, 2020 •
edited
Loading

💔 Tests Failed

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [urso commented: jenkins run tests]

  • Start Time: 2020-07-06T12:14:06.468+0000

  • Duration: 81 min 50 sec

Test stats 🧪

Test Results
Failed 10
Passed 9541
Skipped 1446
Total 10997

Test errors

Expand to view the tests failures

  • Name: Build and Test / Filebeat Windows / test_restart_state_reset_ttl – test_registrar.Test

    • Age: 1
    • Duration: 10.431
    • Error Details: Timeout waiting for 'cond' to be true. Waited 10 seconds.

  • Name: Build and Test / Filebeat Windows / test_restart_state_reset_ttl_with_space – test_registrar.Test

    • Age: 1
    • Duration: 10.456
    • Error Details: Timeout waiting for 'cond' to be true. Waited 10 seconds.

  • Name: Build and Test / Filebeat Windows / test_state_after_rotation – test_registrar.Test

    • Age: 1
    • Duration: 17.29
    • Error Details: Timeout waiting for 'cond' to be true. Waited 15 seconds.

  • Name: Build and Test / Filebeat Windows / test_state_after_rotation_ignore_older – test_registrar.Test

    • Age: 1
    • Duration: 17.282
    • Error Details: Timeout waiting for 'cond' to be true. Waited 15 seconds.

  • Name: Build and Test / Filebeat oss / test_clean_removed – test_registrar.Test

    • Age: 1
    • Duration: 10.586
    • Error Details: Timeout waiting for 'cond' to be true. Waited 10 seconds.

  • Name: Build and Test / Filebeat oss / test_restart_state_reset_ttl – test_registrar.Test

    • Age: 1
    • Duration: 10.402
    • Error Details: Timeout waiting for 'cond' to be true. Waited 10 seconds.

  • Name: Build and Test / Filebeat oss / test_restart_state_reset_ttl_with_space – test_registrar.Test

    • Age: 1
    • Duration: 10.358
    • Error Details: Timeout waiting for 'cond' to be true. Waited 10 seconds.

  • Name: Build and Test / Filebeat oss / test_rotating_file_inode – test_registrar.Test

    • Age: 1
    • Duration: 10.374
    • Error Details: Timeout waiting for 'cond' to be true. Waited 10 seconds.

  • Name: Build and Test / Filebeat oss / test_state_after_rotation – test_registrar.Test

    • Age: 1
    • Duration: 17.213
    • Error Details: Timeout waiting for 'cond' to be true. Waited 15 seconds.

  • Name: Build and Test / Filebeat oss / test_state_after_rotation_ignore_older – test_registrar.Test

    • Age: 1
    • Duration: 17.221
    • Error Details: Timeout waiting for 'cond' to be true. Waited 15 seconds.

Steps errors

Expand to view the steps failures

  • Name: Report to Codecov

    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Duration: 2 min 22 sec

    • Start Time: 2020-07-06T12:38:31.095+0000

    • log

  • Name: Make -C filebeat testsuite

    • Description: make -C filebeat testsuite

    • Duration: 33 min 52 sec

    • Start Time: 2020-07-06T12:36:35.908+0000

    • log

  • Name: Mage build unitTest

    • Description: mage build unitTest

    • Duration: 13 min 34 sec

    • Start Time: 2020-07-06T12:47:55.788+0000

    • log

  • Name: Recursively delete the current directory from the workspace

    • Description: script returned exit code -1

    • Duration: 0 min 11 sec

    • Start Time: 2020-07-06T13:00:46.297+0000

    • log

  • Name: Report to Codecov

    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Duration: 1 min 29 sec

    • Start Time: 2020-07-06T12:54:06.623+0000

    • log

  • Name: Mage build unitTest

    • Description: mage build unitTest

    • Duration: 10 min 22 sec

    • Start Time: 2020-07-06T12:40:55.873+0000

    • log

  • Name: Report to Codecov

    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Duration: 2 min 22 sec

    • Start Time: 2020-07-06T13:26:22.196+0000

    • log

  • Name: Report to Codecov

    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Duration: 2 min 22 sec

    • Start Time: 2020-07-06T13:29:02.833+0000

    • log

  • Name: Report to Codecov

    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Duration: 2 min 22 sec

    • Start Time: 2020-07-06T13:32:05.102+0000

    • log

  • Name: Report to Codecov

    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Duration: 1 min 28 sec

    • Start Time: 2020-07-06T13:22:30.048+0000

    • log

Log output

Expand to view the last 100 lines of log output 

[2020-07-06T13:34:27.868Z] + [ -f packetbeat/build/coverage/full.cov ]
[2020-07-06T13:34:27.868Z] + FILE=winlogbeat/build/coverage/full.cov
[2020-07-06T13:34:27.868Z] + [ -f winlogbeat/build/coverage/full.cov ]
[2020-07-06T13:34:27.868Z] + FILE=journalbeat/build/coverage/full.cov
[2020-07-06T13:34:27.868Z] + [ -f journalbeat/build/coverage/full.cov ]
[2020-07-06T13:34:28.434Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats
[2020-07-06T13:34:28.744Z] + find . -type f -name TEST*.xml -path */build/* -delete
[2020-07-06T13:34:28.757Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Lint
[2020-07-06T13:34:28.843Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Winlogbeat-oss
[2020-07-06T13:34:28.916Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Elastic-Agent-x-pack
[2020-07-06T13:34:28.993Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Auditbeat-crosscompile
[2020-07-06T13:34:29.066Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Dockerlogbeat
[2020-07-06T13:34:29.146Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Journalbeat-oss
[2020-07-06T13:34:29.223Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Generators-Metricbeat-Linux
[2020-07-06T13:34:29.303Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Functionbeat-x-pack
[2020-07-06T13:34:29.383Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Elastic-Agent-x-pack-Windows
[2020-07-06T13:34:29.460Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Metricbeat-OSS-Unit-tests
[2020-07-06T13:34:29.539Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Metricbeat-crosscompile
[2020-07-06T13:34:29.617Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Auditbeat-x-pack-Windows
[2020-07-06T13:34:29.692Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Heartbeat-oss
[2020-07-06T13:34:29.783Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Auditbeat-oss-Windows
[2020-07-06T13:34:29.859Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Auditbeat-x-pack
[2020-07-06T13:34:29.931Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Libbeat-x-pack
[2020-07-06T13:34:30.009Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Winlogbeat-Windows-x-pack
[2020-07-06T13:34:30.084Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Filebeat-x-pack-Windows
[2020-07-06T13:34:30.159Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Filebeat-Windows
[2020-07-06T13:34:30.239Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Elastic-Agent-Mac-OS-X
[2020-07-06T13:34:30.311Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Packetbeat-oss
[2020-07-06T13:34:30.384Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Auditbeat-oss-Mac-OS-X
[2020-07-06T13:34:30.465Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Filebeat-x-pack-Mac-OS-X
[2020-07-06T13:34:30.539Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Auditbeat-oss-Linux
[2020-07-06T13:34:30.610Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Winlogbeat-Windows
[2020-07-06T13:34:30.681Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Metricbeat-x-pack-Windows
[2020-07-06T13:34:30.752Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Metricbeat-Windows
[2020-07-06T13:34:30.825Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Auditbeat-x-pack-Mac-OS-X
[2020-07-06T13:34:30.898Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Filebeat-x-pack
[2020-07-06T13:34:30.970Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Generators-Beat-Linux
[2020-07-06T13:34:31.040Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Filebeat-Mac-OS-X
[2020-07-06T13:34:31.118Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Functionbeat-Mac-OS-X-x-pack
[2020-07-06T13:34:31.190Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Metricbeat-Mac-OS-X
[2020-07-06T13:34:31.262Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Heartbeat-Mac-OS-X
[2020-07-06T13:34:31.336Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Filebeat-oss
[2020-07-06T13:34:31.408Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Metricbeat-Python-integration-tests
[2020-07-06T13:34:31.481Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Metricbeat-x-pack-Mac-OS-X
[2020-07-06T13:34:31.554Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Metricbeat-OSS-Integration-tests
[2020-07-06T13:34:31.628Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Generators-Metricbeat-Mac-OS-X
[2020-07-06T13:34:31.700Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Functionbeat-Windows
[2020-07-06T13:34:31.775Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Libbeat-oss
[2020-07-06T13:34:31.847Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Heartbeat-Windows
[2020-07-06T13:34:31.921Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Generators-Beat-Mac-OS-X
[2020-07-06T13:34:32.001Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Libbeat-crosscompile
[2020-07-06T13:34:32.075Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Libbeat-stress-tests
[2020-07-06T13:34:32.152Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Metricbeat-x-pack
[2020-07-06T13:34:32.528Z] + cat
[2020-07-06T13:34:32.528Z] + /usr/local/bin/runbld ./runbld-script
[2020-07-06T13:34:32.528Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-07-06T13:34:39.127Z] runbld>>> runbld started
[2020-07-06T13:34:39.127Z] runbld>>> 1.6.12/f45d832f2ba0aa2722ab4ec1fda8ad140f027f8b
[2020-07-06T13:34:41.049Z] runbld>>> The following profiles matched the job 'Beats/beats-beats-mbp/PR-19633' in order of occurrence in the config (last value wins).
[2020-07-06T13:34:42.434Z] runbld>>> Debug logging enabled.
[2020-07-06T13:34:42.434Z] runbld>>> Storing result
[2020-07-06T13:34:42.434Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-07-06T13:34:42.434Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200706133442-8DA942B2
[2020-07-06T13:34:42.434Z] runbld>>> Adding system facts.
[2020-07-06T13:34:43.382Z] runbld>>> Adding vcs info for the latest commit:  0b2cbdec25899e9e5e511fa420ec20f7e3557ca9
[2020-07-06T13:34:43.382Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-07-06T13:34:43.382Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-07-06T13:34:43.644Z] + echo 'Processing JUnit reports with runbld...'
[2020-07-06T13:34:43.644Z] Processing JUnit reports with runbld...
[2020-07-06T13:34:43.905Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-07-06T13:34:43.905Z] runbld>>> DURATION: 30ms
[2020-07-06T13:34:43.905Z] runbld>>> STDOUT: 40 bytes
[2020-07-06T13:34:43.905Z] runbld>>> STDERR: 49 bytes
[2020-07-06T13:34:43.905Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-07-06T13:34:43.905Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats
[2020-07-06T13:34:44.850Z] runbld>>> Storing build metadata: 
[2020-07-06T13:34:44.850Z] runbld>>> Adding test report.
[2020-07-06T13:34:44.850Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats
[2020-07-06T13:34:45.793Z] runbld>>> Found 114 test output files
[2020-07-06T13:34:46.054Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-istio.xml
[2020-07-06T13:34:46.054Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-tomcat.xml
[2020-07-06T13:34:46.054Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-iis.xml
[2020-07-06T13:34:46.054Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-openmetrics.xml
[2020-07-06T13:34:46.054Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-activemq.xml
[2020-07-06T13:34:47.455Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Metricbeat-OSS-Integration-tests/metricbeat/build/TEST-go-integration-graphite.xml
[2020-07-06T13:34:47.716Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633/src/github.com/elastic/beats/Metricbeat-OSS-Integration-tests/metricbeat/build/TEST-go-integration-windows.xml
[2020-07-06T13:34:47.978Z] runbld>>> Test output logs contained: Errors: 10 Failures: 0 Tests: 10847 Skipped: 1207
[2020-07-06T13:34:47.978Z] runbld>>> Storing result
[2020-07-06T13:34:47.978Z] runbld>>> FAILURES: 10
[2020-07-06T13:34:50.525Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-07-06T13:34:50.525Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200706133442-8DA942B2
[2020-07-06T13:34:50.525Z] runbld>>> Email notification disabled by environment variable.
[2020-07-06T13:34:50.525Z] runbld>>> Slack notification disabled by environment variable.
[2020-07-06T13:34:56.261Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19633
[2020-07-06T13:34:56.362Z] [INFO] getVaultSecret: Getting secrets
[2020-07-06T13:34:56.422Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-07-06T13:34:57.187Z] + chmod 755 generate-build-data.sh
[2020-07-06T13:34:57.187Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-19633/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-19633/runs/9 FAILURE 4850460
[2020-07-06T13:34:57.187Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-19633/runs/9/steps/?limit=10000 -o steps-info.json
[2020-07-06T13:34:59.670Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-19633/runs/9/tests/?status=FAILED -o tests-errors.json

@urso
Copy link
Author

urso commented Jul 3, 2020

jenkins run the tests please

kvch
kvch reviewed Jul 3, 2020
View reviewed changes
filebeat/registrar/migrate.go Outdated Show resolved Hide resolved
kvch
kvch reviewed Jul 3, 2020
View reviewed changes
Copy link
Contributor

@kvch kvch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Otherwise, I am very happy with how the change has turned out. It is much more readable and understandable. Thank you!

@urso urso force-pushed the filebeat-registrar-statestore branch from cadc674 to 91d5661 Compare July 3, 2020 23:36
@kvch
Copy link
Contributor

kvch commented Jul 6, 2020

jenkins run tests

kvch
kvch approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@kvch kvch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFG

@urso
Copy link
Author

urso commented Jul 6, 2020

jenkins run tests

urso added 5 commits July 6, 2020 22:13
Update filebeat registrar to use statestore
dff9cb8 
Update filebeat registrar, initialization and testing to use the
statestore as new persistent storage backend between restarts
Fix darwin build
d067522
review
c428eb3
remove wrong comment
a887251
fix debug logs and test
3eb7ab5
@urso urso force-pushed the filebeat-registrar-statestore branch from 91d5661 to 3eb7ab5 Compare July 6, 2020 20:24
@urso urso mentioned this pull request Jul 6, 2020
Merged
2 tasks
@urso
Copy link
Author

urso commented Jul 6, 2020

All related tests are green

@urso urso merged commit 5c719cf into elastic:master Jul 6, 2020
@urso urso deleted the filebeat-registrar-statestore branch July 6, 2020 21:50
@urso urso mentioned this pull request Jul 8, 2020
Merged
3 tasks
@urso urso removed the needs_backport PR is waiting to be backported to other branches. label Jul 8, 2020
urso pushed a commit to urso/beats that referenced this pull request Jul 8, 2020
Update filebeat registrar to use statestore (elastic#19633)
b4bf13b 
Update filebeat registrar, initialization and testing to use the
statestore as new persistent storage backend between restarts.

This PR swaps out the storage backend, adds support for migrating old registry files to the statestore, and updates existing tests in filebeat. The migration support extends the already existing migration support, supporting old registry files from the 6.x release as well (system tests start at 6.3).

(cherry picked from commit 5c719cf)
urso pushed a commit that referenced this pull request Jul 8, 2020
Cherry-pick #19633 to 7.x: Update filebeat registrar to use statestore (
399c026 
#19743)
@urso urso mentioned this pull request Jul 8, 2020
Merged
2 tasks
@ChrsMark ChrsMark mentioned this pull request Aug 11, 2020
Closed
v1v added a commit to v1v/beats-tester that referenced this pull request Sep 2, 2020
@v1v
Update registry path for 7.9
eb2d894 
The registry path changed in elastic/beats#19633
@v1v v1v mentioned this pull request Sep 2, 2020
Merged
v1v added a commit to elastic/beats-tester that referenced this pull request Sep 2, 2020
@v1v
Update registry path for 7.9 (#166)
b75af14 
The registry path changed in elastic/beats#19633
@vsxen
Copy link

vsxen commented Sep 18, 2020

This is a Breaking Changes ?

melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@melchiormoulin
Update filebeat registrar to use statestore (elastic#19633)
8957522 
Update filebeat registrar, initialization and testing to use the
statestore as new persistent storage backend between restarts.

This PR swaps out the storage backend, adds support for migrating old registry files to the statestore, and updates existing tests in filebeat. The migration support extends the already existing migration support, supporting old registry files from the 6.x release as well (system tests start at 6.3).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvch kvch kvch approved these changes

Assignees
No one assigned
Labels
Filebeat Filebeat Project:Filebeat-Input-v2 review skip-test-plan Team:Services (Deprecated) Label for the former Integrations-Services team v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@urso @elasticmachine @kvch @vsxen @andresrc