Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Instrumentation configuration #19765

Merged
merged 6 commits into from
Jul 15, 2020
Merged

docs: Instrumentation configuration #19765

merged 6 commits into from
Jul 15, 2020

Conversation

bmorelli25
Copy link
Member

What does this PR do?

This PR adds documentation for the APM tracer instrumentation.

Why is it important?

It adds documentation for a feature added in #17938.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

For https://github.com/elastic/observability-dev/issues/947

@bmorelli25 bmorelli25 added the docs label Jul 9, 2020
@bmorelli25 bmorelli25 requested a review from jalvz July 9, 2020 03:30
@bmorelli25 bmorelli25 self-assigned this Jul 9, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 9, 2020
@bmorelli25
Copy link
Member Author

@jalvz - Here's a barebones PR with some documentation for instrumentation.*. Can you please take a look and leave any comments that you have? In addition, I don't know much about the profiling configuration options.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 9, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19765 updated]

  • Start Time: 2020-07-13T18:04:45.364+0000

  • Duration: 22 min 18 sec

jalvz
jalvz approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@jalvz jalvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks Brandon!!

I will summon @axw because I will be on vacation next week, and he will be back from his...

axw
axw approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

libbeat/docs/shared-instrumentation.asciidoc Outdated Show resolved Hide resolved
@andresrc andresrc added the Team:apm APM Server team issues/PRs label Jul 13, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 13, 2020
@bmorelli25 bmorelli25 marked this pull request as ready for review July 13, 2020 15:53
@bmorelli25 bmorelli25 requested a review from a team as a code owner July 13, 2020 15:53
@bmorelli25
Copy link
Member Author

@elasticmachine, run elasticsearch-ci/docs

@bmorelli25 bmorelli25 merged commit 6317bad into elastic:master Jul 15, 2020
@bmorelli25 bmorelli25 deleted the instrumentation-docs branch July 15, 2020 17:50
This was referenced Jul 15, 2020
Merged
Merged
bmorelli25 added a commit to bmorelli25/beats that referenced this pull request Jul 15, 2020
@bmorelli25
docs: Instrumentation configuration (elastic#19765)
4e30c23
bmorelli25 added a commit to bmorelli25/beats that referenced this pull request Jul 15, 2020
@bmorelli25
docs: Instrumentation configuration (elastic#19765)
9f26162
@bmorelli25 bmorelli25 mentioned this pull request Jul 15, 2020
Merged
bmorelli25 added a commit that referenced this pull request Jul 21, 2020
@bmorelli25
docs: Instrumentation configuration (#19765) (#19953)
69b6a3a
bmorelli25 added a commit that referenced this pull request Jul 21, 2020
@bmorelli25
docs: Instrumentation configuration (#19765) (#19954)
584fc11
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@bmorelli25 @melchiormoulin
docs: Instrumentation configuration (elastic#19765)
eeba098
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@bmorelli25
docs: Instrumentation configuration (elastic#19765) (elastic#19954)
ea4f532
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axw axw axw approved these changes

@jalvz jalvz jalvz approved these changes

@dedemorton dedemorton Awaiting requested review from dedemorton

Assignees

@bmorelli25 bmorelli25

Labels
docs Team:apm APM Server team issues/PRs v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bmorelli25 @elasticmachine @axw @jalvz @andresrc