Cherry-pick #18683 to 7.x: LIBBEAT: Enhancement Convert dissected values from String to other basic data types and IP #19838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayden
added
[zube]: In Review
backport
Team:Integrations
botelastic
bot
added
the
needs_team
|
Pinging @elastic/integrations (Team:Integrations) |
|
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
removed
the
needs_team
ycombinator
reviewed
Jul 13, 2020
CHANGELOG.next.asciidoc
Outdated
| - Add the `ignore_failure` configuration option to the dissect processor. {pull}19464[19464] | ||
| - Add the `overwrite_keys` configuration option to the dissect processor. {pull}19464[19464] | ||
| - Add support to trim captured values in the dissect processor. {pull}19464[19464] | ||
| - Added the `max_cached_sessions` option to the script processor. {pull}19562[19562] |
ycombinator
reviewed
Jul 13, 2020
| @@ -232,3 +232,179 @@ func TestErrorFlagging(t *testing.T) { | |||
| assert.Error(t, err) | |||
| }) | |||
| } | |||
|
|
|||
| func TestIgnoreFailure(t *testing.T) { | |||
There was a problem hiding this comment.
ahh sorry I missed this before approving...
There was a problem hiding this comment.
woaw! Good catch! You really impressed me 😃
There was a problem hiding this comment.
Hmmm, now it seems like we are completely missing TestProcessorConvert in this backport?
kaiyan-sheng
approved these changes
Jul 13, 2020
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
sayden
force-pushed
the
backport_18683_7.x
branch
from
d8aabf8
to
3a344ac
Compare
…sic data types and IP (elastic#18683) (cherry picked from commit 84d75e5)
sayden
force-pushed
the
backport_18683_7.x
branch
from
3a344ac
to
bc2d629
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #18683 to 7.x branch. Original message:
What does this PR do?
This PR enhances dissect processor to convert string values to integer, long, float, double, boolean or IP. Key and convert data type are separated by
|separator.Why is it important?
It will save CPU cycles converting data from string to other data type using Convert processor
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Added unit and benchmark test cases.
Related issues
Closes elastic/dissect-specification#10