-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] Fix s3 input parsing json file without expand_event_list_from_field #19962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Jul 15, 2020
kaiyan-sheng
added
the
Team:Platforms
Label for the Integrations - Platforms team
label
Jul 15, 2020
Pinging @elastic/integrations-platforms (Team:Platforms) |
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Jul 15, 2020
zube
bot
added
[zube]: Inbox
[zube]: In Progress
and removed
[zube]: In Progress
[zube]: Inbox
labels
Jul 16, 2020
lag13
reviewed
Jul 16, 2020
I just tested this and it works for my use case! Thanks again for working on this @kaiyan-sheng |
Collaborator
kaiyan-sheng
added
[zube]: In Review
review
needs_backport
PR is waiting to be backported to other branches.
and removed
[zube]: In Progress
in progress
Pull request is currently in progress.
labels
Jul 21, 2020
zube
bot
removed
the
needs_backport
PR is waiting to be backported to other branches.
label
Jul 21, 2020
ChrsMark
approved these changes
Jul 22, 2020
6 tasks
6 tasks
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
…rom_field (elastic#19962) * Fix s3 input parsing json file without expand_event_list_from_field
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…n file without expand_event_list_from_field (elastic#20135) * [Filebeat] Fix s3 input parsing json file without expand_event_list_from_field (elastic#19962) * Fix s3 input parsing json file without expand_event_list_from_field (cherry picked from commit 9cf6b12) * update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is to fix s3 input when parsing json files without
expand_event_list_from_field
config parameter.During testing I found
offset
is not working properly for s3 input events, this PR also fix it.Why is it important?
For some logs, such as Cloudflare, json looks like:
instead of with a head field like:
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Create a test log file:
Gzip the log file:
Upload the file to S3 bucket and add property:
or manually upload this file to s3 bucket and change the property there.
Change filebeat input to s3 in
filebeat.yml
Run
./filebeat -e
Related issues