-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore missing fields in Zeek module in drop_fields #19984
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
added
[zube]: In Review
Team:Services
(Deprecated) Label for the former Integrations-Services team
labels
Jul 16, 2020
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Jul 16, 2020
Pinging @elastic/siem (Team:SIEM) |
andrewkroh
approved these changes
Jul 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kvch
force-pushed
the
fix-filebeat-zeek-drop-fields
branch
from
July 20, 2020 11:01
ac9a389
to
5a9e60e
Compare
2 tasks
kvch
added
v7.10.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Jul 20, 2020
2 tasks
kvch
added a commit
to kvch/beats
that referenced
this pull request
Jul 22, 2020
(cherry picked from commit 25629c7)
kvch
added a commit
to kvch/beats
that referenced
this pull request
Jul 22, 2020
(cherry picked from commit 25629c7)
kvch
added a commit
that referenced
this pull request
Jul 22, 2020
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…e in drop_fields (elastic#20050) * Ignore missing fields in Zeek module in drop_fields (elastic#19984) (cherry picked from commit c60f849) * Fix typo in Changelog Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co> Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR sets
ignore_missing
totrue
in thedrop_fields
processors of the Zeek module.Why is it important?
Sometimes the fields that are supposed to be dropped are missing. If the fields are missing, Filebeat cannot apply the processors properly and drops the events.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.