Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore missing fields in Zeek module in drop_fields #19984

Merged
merged 2 commits into from
Jul 20, 2020

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Jul 16, 2020

What does this PR do?

This PR sets ignore_missing to true in the drop_fields processors of the Zeek module.

Why is it important?

Sometimes the fields that are supposed to be dropped are missing. If the fields are missing, Filebeat cannot apply the processors properly and drops the events.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@kvch kvch added [zube]: In Review Team:Services (Deprecated) Label for the former Integrations-Services team labels Jul 16, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 16, 2020
@kvch kvch requested a review from leehinman July 16, 2020 09:06
@kvch kvch added the Team:SIEM label Jul 16, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@kvch kvch added the needs_backport PR is waiting to be backported to other branches. label Jul 16, 2020
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kvch kvch force-pushed the fix-filebeat-zeek-drop-fields branch from ac9a389 to 5a9e60e Compare July 20, 2020 11:01
@kvch kvch merged commit 25629c7 into elastic:master Jul 20, 2020
@kvch kvch added v7.10.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jul 20, 2020
@kvch kvch added the v7.9.0 label Jul 20, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19984 updated]

  • Start Time: 2020-07-20T11:01:49.663+0000

  • Duration: 50 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 2434
Skipped 385
Total 2819

kvch added a commit to kvch/beats that referenced this pull request Jul 22, 2020
kvch added a commit to kvch/beats that referenced this pull request Jul 22, 2020
kvch added a commit that referenced this pull request Jul 22, 2020
…op_fields (#20050)

* Ignore missing fields in Zeek module in drop_fields (#19984)

(cherry picked from commit 25629c7)

* Fix typo in Changelog

Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>

Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
kvch added a commit that referenced this pull request Jul 22, 2020
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@zube zube bot removed the [zube]: Done label Oct 18, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…e in drop_fields (elastic#20050)

* Ignore missing fields in Zeek module in drop_fields (elastic#19984)

(cherry picked from commit c60f849)

* Fix typo in Changelog

Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>

Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Services (Deprecated) Label for the former Integrations-Services team v7.9.0 v7.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants