-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick #20112 to 7.9: [libbeat] Fix write error in ensureWriter.Write #20145
Conversation
(cherry picked from commit 787144f)
Pinging @elastic/integrations (Team:Integrations) |
💔 Tests FailedExpand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ---------------------- Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
* upstream/7.9: (32 commits) feat(ci): support storing artifacts for PRs in separate dirs (elastic#20282) (elastic#20301) Cisco ASA: Fix message 106100 (elastic#20245) (elastic#20277) [CI] Change upstream reference (elastic#20296) (elastic#20297) [docs] Fix Windows download link for agent (elastic#20258) (elastic#20290) Cherry-pick to 7.9: [docs] Rename release highlights to what's new (elastic#20255) (elastic#20285) Elastic agent on k8s (elastic#19727) (elastic#20262) [Filebeat Module] Defender ATP - Adding dashboard (elastic#20058) (elastic#20093) fix: use a fixed worker type for tests (elastic#20130) (elastic#20247) [Elastic Agent] Fix Windows powershell install service script (elastic#20203) (elastic#20252) [Ingest Manager] Fixed unzip on older windows (elastic#20088) (elastic#20109) adding possibility to override content-type checks, it was breaking certain webhooks that is not able to set content-headers at all. Still defaults to application/json (elastic#20232) (elastic#20237) [Filebeat][Gsuite] Make GSuite docs more clear (elastic#19981) (elastic#20067) Increase index.max_docvalue_fields_search to 200 (elastic#20218) (elastic#20221) Call host parser only once when building light metricsets (elastic#20149) (elastic#20190) [Metricbeat] Use MySQL Host Parser in Query metricset (elastic#20191) (elastic#20212) [Filebeat] Ignore cylance.protect timestamps while testing (elastic#20207) (elastic#20217) [libbeat] Fix write error in ensureWriter.Write (elastic#20112) (elastic#20145) Cherry-pick elastic#20127 to 7.9: Fix failing unit tests on windows (elastic#20180) Remove f5/firepass rsa2elk fileset (elastic#20160) (elastic#20206) Cherry-pick elastic#20138 to 7.9: [Filebeat] Update crowdstrike module (elastic#20177) ...
…tic#20145) (cherry picked from commit 11c0a37)
Cherry-pick of PR #20112 to 7.9 branch. Original message:
What does this PR do?
The internal helper
ensureWriter.Write
is supposed to keep writing as long as the encapsulated writer returns a retriable error, however the test is inverted in the current code and terminates on retriable errors / retries on permanent ones.Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.