Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify doc in app_insights metricset #20185

Merged
merged 2 commits into from
Jul 30, 2020
Merged

Conversation

narph
Copy link
Contributor

@narph narph commented Jul 23, 2020

What does this PR do?

Updates documentation

Why is it important?

Offers example config

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 23, 2020
@narph narph self-assigned this Jul 23, 2020
@narph narph added [zube]: In Review needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team labels Jul 23, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 23, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 23, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20185 updated]

  • Start Time: 2020-07-23T09:07:58.909+0000

  • Duration: 23 min 36 sec

@kaiyan-sheng kaiyan-sheng merged commit 3b4cdc2 into elastic:master Jul 30, 2020
@kaiyan-sheng
Copy link
Contributor

@narph Thanks for fixing the doc. I hope you don't mind me merging this. I will also make the cherrypicks.

@kaiyan-sheng kaiyan-sheng added v7.10.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jul 30, 2020
v1v added a commit to v1v/beats that referenced this pull request Jul 31, 2020
…ne-2.0

* upstream/master:
  Check expand_event_list_from_field when json in map[string]interface{} format (elastic#20370)
  [docs] Remove deprecated security roles (elastic#20162)
  Modify doc in app_insights metricset (elastic#20185)
v1v added a commit to v1v/beats that referenced this pull request Jul 31, 2020
…allation

* upstream/master:
  Check expand_event_list_from_field when json in map[string]interface{} format (elastic#20370)
  [docs] Remove deprecated security roles (elastic#20162)
  Modify doc in app_insights metricset (elastic#20185)
  [Elastic Agent] Add skeleton for client/server for agent control protocol (elastic#20163)
  Auditbeat: Allow multiple instances by grouping kprobes by PID (elastic#20325)
  [Filebeat][Fortinet] Remove pre populated event.timezone (elastic#20273)
  Add an explicit system test for processes on unix systems (elastic#20320)
kaiyan-sheng added a commit that referenced this pull request Jul 31, 2020
(cherry picked from commit 3b4cdc2)

Co-authored-by: Mariana Dima <mariana@elastic.co>
kaiyan-sheng added a commit that referenced this pull request Jul 31, 2020
(cherry picked from commit 3b4cdc2)

Co-authored-by: Mariana Dima <mariana@elastic.co>
@narph narph deleted the modify-app branch September 28, 2020 15:22
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
elastic#20363)

(cherry picked from commit aff5f2d)

Co-authored-by: Mariana Dima <mariana@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants