-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ingest Manager] Prevent closing closed reader #20214
[Ingest Manager] Prevent closing closed reader #20214
Conversation
I thing this change is causing the e2e tests to fail: https://beats-ci.elastic.co/blue/organizations/jenkins/e2e-tests%2Fe2e-testing-mbp/detail/master/91/pipeline#step-240-log-144
We download the elastic-agent TAR file and mount a volume in the container so that we can untar it in the running Centos container. And for the stand-alone mode, the elastic-agent docker image fails too: https://beats-ci.elastic.co/blue/organizations/jenkins/e2e-tests%2Fe2e-testing-mbp/detail/master/91/pipeline/207#step-240-log-144 |
@mdelapenya the error you're describing is cause by #20127 this one should fix it. |
Cool then! Do you know when the build artifacts will be generated? |
…ne-2.0 * upstream/master: (41 commits) adding possibility to override content-type checks, it was breaking certain webhooks that is not able to set content-headers at all. Still defaults to application/json (elastic#20232) fix: use a fixed worker type for tests (elastic#20130) [Ingest Manager] Prepare packaging for endpoint and asc files (elastic#20186) [Packetbeat] HTTP: Improve support for 100-continue elastic#15830 (elastic#19349) Increase index.max_docvalue_fields_search to 200 (elastic#20218) [Ingest Manager] Prevent closing closed reader (elastic#20214) [Metricbeat] Use MySQL Host Parser in Query metricset (elastic#20191) Testing: Ignore timestamp from cylance/protect dataset (elastic#20211) [Filebeat] Ignore cylance.protect timestamps while testing (elastic#20207) [CI] remove codecov step (elastic#20102) [docs] Indicate that SYSTEM user is required on Windows to use Endpoint (elastic#20172) Remove f5/firepass rsa2elk fileset (elastic#20160) [Elastic Agent] Improve GRPC stop to be more relaxed. (elastic#20118) Fix fileset field prefixing (elastic#20170) Fix terminating pod autodiscover issue (elastic#20084) Call host parser only once when building light metricsets (elastic#20149) [CI] fix null string with contains (elastic#20182) [Ingest Manager] Fix failing unit tests on windows (elastic#20127) [Filebeat] Update crowdstrike module (elastic#20138) [docs] Add x-pack role to relevant metricsets (elastic#20167) ...
The release manager build the artifact daily, but we have a ci job that build beats and elastic-agent on every commit. |
This URL hasn't changed for days: https://artifacts-api.elastic.co/v1/search/8.0.0-SNAPSHOT/elastic-agent Do you know where are we pushing those commit-based artifacts (docker image and binaries)? |
@mdelapenya Yes, you are right, looking at CI it's been failing for a few days. There a build going on. |
@mdelapenya It was failing because of beats 04:50:47 org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':buildBeatsSnapshot'. Next build should fix the issue it include 59ddf55 |
* prevent closing closed * changelog
What does this PR do?
With #20127 config reader is closed on read. no need to do that in code. removes all occurences of close
Why is it important?
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.