Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #20245 to 7.8: Cisco ASA: Fix message 106100 #20279

Merged
merged 2 commits into from
Jul 29, 2020
Merged

Cherry-pick #20245 to 7.8: Cisco ASA: Fix message 106100 #20279

merged 2 commits into from
Jul 29, 2020

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Jul 28, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #20245 to 7.8 branch. Original message:

What does this PR do?

This updates the parser for Cisco ASA message 106100 so that it doesn't fail when extra information is appended after the port numbers.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Fixes #19350

@adriansr
Cisco ASA: Fix message 106100 (elastic#20245)
06d2d6d 
This updates the parser for Cisco ASA message 106100 so that it doesn't
fail when extra information is appended after the port numbers.

Fixes elastic#19350

(cherry picked from commit ac688ca)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 28, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 28, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 28, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20279 updated]

  • Start Time: 2020-07-29T10:19:25.240+0000

  • Duration: 45 min 9 sec

Test stats 🧪

Test Results
Failed 0
Passed 2195
Skipped 385
Total 2580

@adriansr
Update golden files
64049ad 
Different features in 7.8 vs >7.8 yield different fields.
@adriansr adriansr merged commit 6959227 into elastic:7.8 Jul 29, 2020
@zube zube bot removed the [zube]: Done label Oct 28, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@adriansr
Cherry-pick elastic#20245 to 7.8: Cisco ASA: Fix message 106100 (elas…
e7c9da0 
…tic#20279)

This updates the parser for Cisco ASA message 106100 so that it doesn't
fail when extra information is appended after the port numbers.

Fixes elastic#19350

(cherry picked from commit 170f9c2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adriansr @elasticmachine @andrewkroh