Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cisco asa/ftd parsing of msgs 106102/106103 #20469

Merged
merged 4 commits into from
Aug 7, 2020

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Aug 6, 2020

What does this PR do?

Updates the parsers for messages 106102 and 106103 in the shared Cisco asa/ftd pipeline.

Why is it important?

The documentation on messages 106102 and 106103 didn't match the actual format used by devices. This is causing errors when trying to ingest those messages.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Logs

The error this fixes:

(status=400): {
    "type":"mapper_parsing_exception",
    "reason":"failed to parse field [destination.port] of type [long] in document with id '4lFGv3MBi145cg_j1NOE'. Preview of field's value: 'hit-cnt'",
    "caused_by":{
      "type":"illegal_argument_exception",
      "reason":"For input string: \"hit-cnt\""
    }
  }

These documentation on those messages didn't match the actual format
used by devices.
@adriansr adriansr added bug review needs_backport PR is waiting to be backported to other branches. Team:SIEM labels Aug 6, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 6, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20469 updated]

  • Start Time: 2020-08-06T13:37:15.512+0000

  • Duration: 49 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 2438
Skipped 397
Total 2835

@adriansr adriansr merged commit 7ec32e4 into elastic:master Aug 7, 2020
adriansr added a commit to adriansr/beats that referenced this pull request Aug 7, 2020
These documentation on those messages didn't match the actual format
used by devices.

(cherry picked from commit 7ec32e4)
@adriansr adriansr added v7.10.0 and removed needs_backport PR is waiting to be backported to other branches. labels Aug 7, 2020
adriansr added a commit to adriansr/beats that referenced this pull request Aug 7, 2020
These documentation on those messages didn't match the actual format
used by devices.

(cherry picked from commit 7ec32e4)
@adriansr adriansr added the v7.9.0 label Aug 7, 2020
adriansr added a commit that referenced this pull request Aug 10, 2020
…06103 (#20493)

These documentation on those messages didn't match the actual format
used by devices.

(cherry picked from commit 7ec32e4)
adriansr added a commit that referenced this pull request Aug 10, 2020
These documentation on those messages didn't match the actual format
used by devices.

(cherry picked from commit 7ec32e4)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
These documentation on those messages didn't match the actual format
used by devices.
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…tic#20494)

These documentation on those messages didn't match the actual format
used by devices.

(cherry picked from commit 78883bb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants