Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Golang version to 1.14.7 #20508

Merged
merged 2 commits into from
Aug 11, 2020
Merged

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Aug 10, 2020

What does this PR do?

This PR updates the Golang version to 1.14.7.

Why is it important?

This PR is important because there have been numerous bug fixes and improvements in Golang 1.14 since the version we are using at the moment. The last release contains a security fix of the package encoding/binary. Both we and our dependencies rely on this package, so to be safe we should update Golang.

It would be nice to update on 7.9 as well.

Checklist

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas

  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@kvch kvch added [zube]: In Review Team:Services (Deprecated) Label for the former Integrations-Services team labels Aug 10, 2020
@kvch kvch requested a review from a team as a code owner August 10, 2020 09:40
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 10, 2020
@kvch kvch added the needs_backport PR is waiting to be backported to other branches. label Aug 10, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 10, 2020

❕ Build Aborted

Either there was a build timeout or someone aborted the build.'}

Pipeline View Test View Changes Artifacts

Expand to view the summary

Build stats

  • Build Cause: [kvch commented: jenkins run tests]

  • Start Time: 2020-08-11T11:02:04.046+0000

  • Duration: 123 min 44 sec

Test stats 🧪

Test Results
Failed 0
Passed 11910
Skipped 1250
Total 13160

Steps errors

Expand to view the steps failures

  • Name: Error signal

    • Description: untar: step failed with error null

    • Duration: 0 min 0 sec

    • Start Time: 2020-08-11T13:04:46.631+0000

    • log

  • Name: Cleanup

    • Description: rm source.tgz

    • Duration: 0 min 0 sec

    • Start Time: 2020-08-11T13:04:46.673+0000

    • log

Log output

Expand to view the last 100 lines of log output

[2020-08-11T12:23:19.672Z] ++ uname -s
[2020-08-11T12:23:19.672Z] ++ tr '[:upper:]' '[:lower:]'
[2020-08-11T12:23:19.672Z] + OS=linux
[2020-08-11T12:23:19.672Z] + command -v terraform
[2020-08-11T12:23:19.672Z] + echo 'UNMET DEP: Installing Terraform'
[2020-08-11T12:23:19.672Z] UNMET DEP: Installing Terraform
[2020-08-11T12:23:19.672Z] + mkdir -p /var/lib/jenkins/workspace/Beats_beats_PR-20508/bin
[2020-08-11T12:23:19.672Z] + curl -sSLo - https://releases.hashicorp.com/terraform/0.12.24/terraform_0.12.24_linux_amd64.zip
[2020-08-11T12:23:20.243Z] ++ dirname /var/lib/jenkins/workspace/Beats_beats_PR-20508/bin/terraform
[2020-08-11T12:23:20.243Z] + unzip -o /var/lib/jenkins/workspace/Beats_beats_PR-20508/bin/terraform.zip -d /var/lib/jenkins/workspace/Beats_beats_PR-20508/bin
[2020-08-11T12:23:20.243Z] Archive:  /var/lib/jenkins/workspace/Beats_beats_PR-20508/bin/terraform.zip
[2020-08-11T12:23:20.818Z]   inflating: /var/lib/jenkins/workspace/Beats_beats_PR-20508/bin/terraform  
[2020-08-11T12:23:20.818Z] + rm /var/lib/jenkins/workspace/Beats_beats_PR-20508/bin/terraform.zip
[2020-08-11T12:23:20.818Z] + chmod +x /var/lib/jenkins/workspace/Beats_beats_PR-20508/bin/terraform
[2020-08-11T12:23:21.191Z] + make mage
[2020-08-11T12:23:21.191Z] Installing mage v1.10.0.
[2020-08-11T12:23:22.722Z] go: downloading github.com/magefile/mage v1.10.0
[2020-08-11T12:23:26.036Z] /var/lib/jenkins/workspace/Beats_beats_PR-20508/.magefile cleaned
[2020-08-11T12:23:26.376Z] + git config --get user.email
[2020-08-11T12:23:26.376Z] + [ -z  ]
[2020-08-11T12:23:26.376Z] + git config user.email beatsmachine@users.noreply.github.com
[2020-08-11T12:23:26.376Z] + git config user.name beatsmachine
[2020-08-11T12:23:27.000Z] + .ci/scripts/terraform-cleanup.sh x-pack/metricbeat
[2020-08-11T12:23:27.000Z] + DIRECTORY=x-pack/metricbeat
[2020-08-11T12:23:27.000Z] + FAILED=0
[2020-08-11T12:23:27.000Z] ++ find x-pack/metricbeat -name terraform.tfstate
[2020-08-11T12:23:27.000Z] + exit 0
[2020-08-11T13:03:46.618Z] Cancelling nested steps due to timeout
[2020-08-11T13:03:46.621Z] 
Creating libbeat_8_0_0_df1d3ebae6-snapshot_logstash_1                       ... done
Sending interrupt signal to process
[2020-08-11T13:03:50.183Z] Sending interrupt signal to process
[2020-08-11T13:04:00.608Z] failed to run compiled magefile: signal: terminated
[2020-08-11T13:04:00.616Z] script returned exit code 255
[2020-08-11T13:04:01.016Z] Client: Docker Engine - Community
[2020-08-11T13:04:01.016Z]  Version:           19.03.12
[2020-08-11T13:04:01.016Z]  API version:       1.40
[2020-08-11T13:04:01.016Z]  Go version:        go1.13.10
[2020-08-11T13:04:01.016Z]  Git commit:        48a66213fe
[2020-08-11T13:04:01.016Z]  Built:             Mon Jun 22 15:45:36 2020
[2020-08-11T13:04:01.016Z]  OS/Arch:           linux/amd64
[2020-08-11T13:04:01.016Z]  Experimental:      false
[2020-08-11T13:04:01.016Z] 
[2020-08-11T13:04:01.016Z] Server: Docker Engine - Community
[2020-08-11T13:04:01.016Z]  Engine:
[2020-08-11T13:04:01.016Z]   Version:          19.03.12
[2020-08-11T13:04:01.016Z]   API version:      1.40 (minimum version 1.12)
[2020-08-11T13:04:01.016Z]   Go version:       go1.13.10
[2020-08-11T13:04:01.016Z]   Git commit:       48a66213fe
[2020-08-11T13:04:01.016Z]   Built:            Mon Jun 22 15:44:07 2020
[2020-08-11T13:04:01.016Z]   OS/Arch:          linux/amd64
[2020-08-11T13:04:01.016Z]   Experimental:     false
[2020-08-11T13:04:01.016Z]  containerd:
[2020-08-11T13:04:01.016Z]   Version:          1.2.13
[2020-08-11T13:04:01.016Z]   GitCommit:        7ad184331fa3e55e52b890ea95e65ba581ae3429
[2020-08-11T13:04:01.016Z]  runc:
[2020-08-11T13:04:01.016Z]   Version:          1.0.0-rc10
[2020-08-11T13:04:01.016Z]   GitCommit:        dc9208a3303feef5b3839f4323d9beb36df0a9dd
[2020-08-11T13:04:01.016Z]  docker-init:
[2020-08-11T13:04:01.016Z]   Version:          0.18.0
[2020-08-11T13:04:01.016Z]   GitCommit:        fec3683
[2020-08-11T13:04:01.343Z] Unable to find image 'alpine:3.4' locally
[2020-08-11T13:04:01.604Z] 3.4: Pulling from library/alpine
[2020-08-11T13:04:01.865Z] c1e54eec4b57: Pulling fs layer
[2020-08-11T13:04:02.134Z] c1e54eec4b57: Verifying Checksum
[2020-08-11T13:04:02.134Z] c1e54eec4b57: Download complete
[2020-08-11T13:04:02.427Z] c1e54eec4b57: Pull complete
[2020-08-11T13:04:02.427Z] Digest: sha256:b733d4a32c4da6a00a84df2ca32791bb03df95400243648d8c539e7b4cce329c
[2020-08-11T13:04:02.751Z] Status: Downloaded newer image for alpine:3.4
[2020-08-11T13:04:05.652Z] + python .ci/scripts/pre_archive_test.py
[2020-08-11T13:04:05.921Z] Copy ./libbeat/build into build/libbeat/build
[2020-08-11T13:04:05.937Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20508/src/github.com/elastic/beats/build
[2020-08-11T13:04:05.960Z] Recording test results
[2020-08-11T13:04:08.478Z] Stashed 2 file(s)
[2020-08-11T13:04:08.491Z] Archiving artifacts
[2020-08-11T13:04:09.207Z] + python .ci/scripts/search_system_tests.py
[2020-08-11T13:04:09.252Z] [INFO] system-tests='build/libbeat/build/system-tests'. If no empty then let's create a tarball
[2020-08-11T13:04:09.587Z] + tar --version
[2020-08-11T13:04:09.913Z] + tar --exclude=libbeat--system-tests-linux.tgz -czf libbeat--system-tests-linux.tgz build/libbeat/build/system-tests
[2020-08-11T13:04:12.616Z] Archiving artifacts
[2020-08-11T13:04:15.550Z] Stage "Libbeat crosscompile" skipped due to earlier failure(s)
[2020-08-11T13:04:15.610Z] Stage "Libbeat stress-tests" skipped due to earlier failure(s)
[2020-08-11T13:04:15.720Z] Failed in branch Libbeat
[2020-08-11T13:04:25.381Z] [INFO] unstashV2: JOB_GCS_BUCKET is set. bucket param got precedency instead.
[2020-08-11T13:04:25.402Z] [INFO] unstashV2: JOB_GCS_CREDENTIALS is set. credentialsId param got precedency instead.
[2020-08-11T13:04:25.460Z] [Google Cloud Storage Plugin] Found 1 files to download from pattern: gs://beats-ci-temp/Beats/beats/PR-20508-3/source/source.tgz
[2020-08-11T13:04:25.479Z] [Google Cloud Storage Plugin] Downloading: Beats/beats/PR-20508-3/source/source.tgz to local path: /var/lib/jenkins/workspace/Beats_beats_PR-20508/source.tgz
[2020-08-11T13:04:38.536Z] + tar --version
[2020-08-11T13:04:38.836Z] + tar -xpf source.tgz
[2020-08-11T13:04:46.618Z] Body did not finish within grace period; terminating with extreme prejudice
[2020-08-11T13:04:46.629Z] [INFO] source.tgz was not extracted : null
[2020-08-11T13:04:46.959Z] + rm source.tgz
[2020-08-11T13:04:46.968Z] ERROR: runbld post build action failed.
[2020-08-11T13:04:46.968Z] ERROR: untar: step failed with error null
[2020-08-11T13:04:47.137Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats_PR-20508
[2020-08-11T13:04:47.248Z] [INFO] getVaultSecret: Getting secrets
[2020-08-11T13:04:47.331Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-08-11T13:04:48.065Z] + chmod 755 generate-build-data.sh
[2020-08-11T13:04:48.065Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20508/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20508/runs/3 ABORTED 7363759
[2020-08-11T13:04:48.065Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20508/runs/3/steps/?limit=10000 -o steps-info.json
[2020-08-11T13:04:49.927Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20508/runs/3/tests/?status=FAILED -o tests-errors.json
[2020-08-11T13:04:50.838Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20508/runs/3/log/ -o pipeline-log.txt

@andrewkroh
Copy link
Member

/package

@kvch
Copy link
Contributor Author

kvch commented Aug 10, 2020

@andrewkroh I haven't added new images yet, so packaging will fail.

@kvch
Copy link
Contributor Author

kvch commented Aug 10, 2020

Opened PR to update the builders: elastic/golang-crossbuild#66

@kvch
Copy link
Contributor Author

kvch commented Aug 11, 2020

/package

@kvch
Copy link
Contributor Author

kvch commented Aug 11, 2020

jenkins run tests

@kvch
Copy link
Contributor Author

kvch commented Aug 11, 2020

Failing tests are unrelated.

@kvch kvch merged commit 5e96f47 into elastic:master Aug 11, 2020
kvch added a commit to kvch/beats that referenced this pull request Aug 11, 2020
@kvch kvch added v7.10.0 and removed needs_backport PR is waiting to be backported to other branches. labels Aug 11, 2020
kvch added a commit to kvch/beats that referenced this pull request Aug 11, 2020
@kvch kvch added the v7.9.0 label Aug 11, 2020
kvch added a commit that referenced this pull request Aug 12, 2020
kvch added a commit that referenced this pull request Aug 12, 2020
v1v added a commit to v1v/beats that referenced this pull request Aug 12, 2020
…ne-2.0

* upstream/master: (39 commits)
  [ITs] Revert healthcheck for elasticsearchssl service to the previous behaviour (elastic#20558)
  [Heartbeat] Fix packaging (elastic#20566)
  [Heartbeat] Add Magefile to X-Pack (elastic#20549)
  [Packetbeat] Add "network" to event.category (elastic#20392)
  fix typo in docs (elastic#20541)
  Add service resource in k8s cluster role (elastic#20546)
  Update Golang version to 1.14.7 (elastic#20508)
  Add missing inputs to filebeat spec (elastic#20388)
  add warning log in aws and googlecloud module for API cost (elastic#20523)
  Fix fortinet.firewall.mem value to be interpreted as integer (elastic#19335)
  [CI] add more resilience (elastic#20505)
  [JJBB] fix credentials with a service account for golang-crossbuild (elastic#20537)
  [ITs] change healthcheck for elasticsearch (elastic#20514)
  [JJBB] fix credentials with a service account (elastic#20535)
  chore(ci): use build step for checking if is PR (elastic#20536)
  [CI] runbld project name (elastic#20466)
  Add panw.panos.endreason field (elastic#18705)
  [Filebeat] Fix PANW field spelling "veredict" to "verdict" (elastic#18808)
  Fix typo in netflow module docs (elastic#18992)
  Modified auditd ingest pipeline to handle node=hostname (elastic#19659)
  ...
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Services (Deprecated) Label for the former Integrations-Services team v7.9.0 v7.10.0 [zube]: In Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants