Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #19659 to 7.x: Modified auditd ingest pipeline to handle node=hostname format #20526

Merged
merged 2 commits into from
Aug 11, 2020

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Aug 10, 2020

Cherry-pick of PR #19659 to 7.x branch. Original message:

What does this PR do?

This change permits auditd logs to be ingested whether or not they begin with a node=. Previous to this change a type= was expected.

It handles the case where name_format (man 5 auditd.conf) is a value other than none.

Also adding 10 lines of resulting audit log with name_format = hostname parameter on CentOS 7.

Why is it important?

When running auditd with name_format other than none, the log messages will begin with node= parameter rather than type=. This behavior caused such audit logs to fail ingestion. The use case for setting name_format would be with an audit server collecting audit logs from multiple hosts.

Checklist

  • [ X] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
    -~~ [ ] I have made corresponding changes to the documentation~~
    -~~ [ ] I have made corresponding change to the default configuration files~~
    -~~ [ ] I have added tests that prove my fix is effective or that my feature works~~
    -~~ [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.~~

This change permits auditd logs to be ingested whether or not they begin with a node=. Previous to this change a type= was expected.

It handles the case where name_format (man 5 auditd.conf) is a value other than none.

Also adding 10 lines of resulting audit log with name_format = hostname parameter on CentOS 7.

Co-authored-by: Marc Guasch <marc.guasch@elastic.co>
(cherry picked from commit b48be52)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 10, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 10, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 10, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20526 updated]

  • Start Time: 2020-08-11T11:24:00.757+0000

  • Duration: 56 min 8 sec

Test stats 🧪

Test Results
Failed 0
Passed 5509
Skipped 830
Total 6339

CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
@andrewkroh andrewkroh merged commit 2e2af60 into elastic:7.x Aug 11, 2020
@zube zube bot removed the [zube]: Done label Nov 10, 2020
@andrewkroh andrewkroh deleted the backport_19659_7.x branch January 14, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants