Rename cloud.provider to azure instead of az in add_cloud_metadata processor
#20689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
narph
added
[zube]: In Review
needs_backport
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
narph
added a commit
to narph/beats
that referenced
this pull request
Aug 27, 2020
…a processor (elastic#20689) * mofidy doc * rename azure provider in cloud data * changelo (cherry picked from commit d34d1b6)
6 tasks
narph
added a commit
to narph/beats
that referenced
this pull request
Aug 27, 2020
…a processor (elastic#20689) * mofidy doc * rename azure provider in cloud data * changelo (cherry picked from commit d34d1b6)
6 tasks
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
…a processor (elastic#20689) * mofidy doc * rename azure provider in cloud data * changelo
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…stead of `az` in add_cloud_metadata processor (elastic#20823) * Rename cloud.provider to `azure` instead of `az` in add_cloud_metadata processor (elastic#20689) * mofidy doc * rename azure provider in cloud data * changelo (cherry picked from commit ae847fb) * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rename cloud.provider to
azureinstead ofazin add_cloud_metadataWhy is it important?
The cloud.provider's value is
azbut it is matched toazurein theazuremodule.Not sure why it is shorten
azuretoaz. Looking around I do not see theazterminology being a popular one or even used anywhere (maybe in the az client). Unlikeawsorgcp,azureis does not to abbreviate toaz, using azure instead seems to me to be the most reasonable solution.Also, the elastic documentation shows that
azureshould be used instead.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues