Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Kubernetes state metricsets as GA #20901

Merged

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Sep 1, 2020

What does this PR do?

Release all Kubernetes state metricsets as GA.

Why is it important?

We have state metricsets in different levels, let's move them all to GA as they have mostly the same logic and they are being used in the reference manifests.

@jsoriano jsoriano added the Team:Platforms Label for the Integrations - Platforms team label Sep 1, 2020
@jsoriano jsoriano self-assigned this Sep 1, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 1, 2020
Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should even go GA. In the past there was an initiative to merge all state_* metricsets together but we abandoned that path.

@jsoriano jsoriano added needs_backport PR is waiting to be backported to other branches. v7.10.0 labels Sep 1, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 1, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20901 updated]

  • Start Time: 2020-09-03T09:41:28.671+0000

  • Duration: 77 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 3149
Skipped 688
Total 3837

@jsoriano jsoriano changed the title Remove experimental tag from Kubernetes state metricsets Remove Kubernetes state metricsets as GA Sep 2, 2020
@jsoriano jsoriano force-pushed the kubernetes-metricsets-experimental-tags branch from fd848b5 to 8f5428f Compare September 2, 2020 10:41
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jsoriano jsoriano changed the title Remove Kubernetes state metricsets as GA Release Kubernetes state metricsets as GA Sep 2, 2020
@jsoriano jsoriano merged commit 9807eb1 into elastic:master Sep 3, 2020
@jsoriano jsoriano deleted the kubernetes-metricsets-experimental-tags branch September 3, 2020 15:09
jsoriano added a commit to jsoriano/beats that referenced this pull request Sep 3, 2020
@jsoriano jsoriano removed the needs_backport PR is waiting to be backported to other branches. label Sep 3, 2020
v1v added a commit to v1v/beats that referenced this pull request Sep 3, 2020
…ne-2.0

* upstream/master:
  Release Kubernetes state metricsets as GA (elastic#20901)
  Clarify use for shared_credential_file (elastic#20929)
jsoriano added a commit that referenced this pull request Sep 3, 2020
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Platforms Label for the Integrations - Platforms team v7.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants