Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filebeat][Azure Module] Fixing event.outcome from result_type issue #20998

Merged
merged 3 commits into from
Sep 21, 2020
Merged

[Filebeat][Azure Module] Fixing event.outcome from result_type issue #20998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7995b9
fixing a small typo in result type and adding more event.outcome poss…
P1llus Sep 6, 2020
c5e6612
Updating changelog
P1llus Sep 6, 2020
455d7f9
Merge branch 'master' into filebeat_azuremodule_outcomefix
P1llus Sep 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.next.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,6 +555,7 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d
- Convert httpjson to v2 input {pull}20226[20226]
- Improve Zeek x509 module with `x509` ECS mappings {pull}20867[20867]
- Improve Zeek SSL module with `x509` ECS mappings {pull}20927[20927]
- Added new properties field support for event.outcome in azure module {pull}20998[20998]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be reordered

- Improve Zeek Kerberos module with `x509` ECS mappings {pull}20958[20958]

*Heartbeat*
Expand Down
7 changes: 6 additions & 1 deletion x-pack/filebeat/module/azure/activitylogs/ingest/pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,12 @@ processors:
field: azure.activitylogs.result_type
target_field: event.outcome
type: string
if: "ctx?.azure?.activitylogs?.resultType != null && ctx.azure.activitylogs.resultType instanceof String && (ctx.azure.activitylogs.resultType.toLowerCase() == 'success' || ctx.azure.activitylogs.resultType.toLowerCase() == 'failure')"
if: "ctx?.azure?.activitylogs?.result_type != null && ctx.azure.activitylogs.result_type instanceof String && (ctx.azure.activitylogs.result_type.toLowerCase() == 'success' || ctx.azure.activitylogs.result_type.toLowerCase() == 'failure')"
- convert:
field: azure.activitylogs.properties.result
target_field: event.outcome
type: string
if: "ctx?.event?.outcome == null && ctx?.azure?.activitylogs?.properties?.result != null && ctx?.azure?.activitylogs?.properties?.result instanceof String && ['success', 'failure', 'unknown'].contains(ctx.azure?.activitylogs?.properties?.result)"
- rename:
field: azure.activitylogs.operationName
target_field: azure.activitylogs.operation_name
Expand Down
1 change: 1 addition & 0 deletions x-pack/filebeat/module/azure/activitylogs/test/supporttickets_write.log-expected.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
"event.duration": -1468967296,
"event.kind": "event",
"event.module": "azure",
"event.outcome": "success",
"event.type": [
"change"
],
Expand Down