Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes in Cloud Foundry fields #21175

Merged
merged 6 commits into from
Sep 21, 2020

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Sep 18, 2020

What does this PR do?

  • Remove redundant and undocumented cloudfoundry.*.timestamp fields.
  • Add missing documentation about envelope fields.
  • Update data.json files in metricbeat module.

Why is it important?

Avoid unnecessary duplication of data and keep documentation updated.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@jsoriano jsoriano added needs_backport PR is waiting to be backported to other branches. Team:Platforms Label for the Integrations - Platforms team v7.10.0 labels Sep 18, 2020
@jsoriano jsoriano self-assigned this Sep 18, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 18, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 18, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21175 updated]

  • Start Time: 2020-09-18T18:36:15.959+0000

  • Duration: 66 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 6518
Skipped 525
Total 7043

Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general it looks good to me! Does this need to be in sync with #21177 though?

@jsoriano
Copy link
Member Author

In general it looks good to me! Does this need to be in sync with #21177 though?

Thanks! They are independent changes, but I expect conflicts yes 🙂

@jsoriano
Copy link
Member Author

In general it looks good to me! Does this need to be in sync with #21177 though?

Thanks! They are independent changes, but I expect conflicts yes 🙂

I mean, they can be independently merged, but probably I will need to fix merge conflicts in one after merging the other.

@ChrsMark
Copy link
Member

In general it looks good to me! Does this need to be in sync with #21177 though?

Thanks! They are independent changes, but I expect conflicts yes 🙂

I mean, they can be independently merged, but probably I will need to fix merge conflicts in one after merging the other.

Cool! I mostly thought about data.json file which will need to be updated in both.

@jsoriano jsoriano merged commit 3527264 into elastic:master Sep 21, 2020
@jsoriano jsoriano deleted the redundant-cloudfoundry-fields branch September 21, 2020 14:18
jsoriano added a commit to jsoriano/beats that referenced this pull request Sep 21, 2020
Remove redundant and undocumented `cloudfoundry.*.timestamp` fields.
Add missing documentation about envelope fields.
Update `data.json` files in metricbeat module.

(cherry picked from commit 3527264)
@jsoriano jsoriano removed the needs_backport PR is waiting to be backported to other branches. label Sep 21, 2020
jsoriano added a commit that referenced this pull request Sep 22, 2020
Remove redundant and undocumented `cloudfoundry.*.timestamp` fields.
Add missing documentation about envelope fields.
Update `data.json` files in metricbeat module.

(cherry picked from commit 3527264)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Platforms Label for the Integrations - Platforms team v7.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants