Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #21214 to 7.x: [Filebeat][httpjson] Add recursive split to httpjson #21252

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Sep 23, 2020

Cherry-pick of PR #21214 to 7.x branch. Original message:

What does this PR do?

Adds ability to split recursively to have more than one level of split events by functionality.

NOTE: uses the .. notation instead of . to avoid breaking users using . notation currently.

Why is it important?

This will unblock the development of some modules.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

We do not want to add it to the changelog since is only for internal use and to be removed soon

@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 23, 2020
@marc-gr marc-gr requested a review from a team September 23, 2020 13:43
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21252 opened]

  • Start Time: 2020-09-23T13:44:28.404+0000

  • Duration: 72 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 2501
Skipped 388
Total 2889

@marc-gr marc-gr merged commit f29b00f into elastic:7.x Sep 23, 2020
@marc-gr marc-gr deleted the backport_21214_7.x branch September 23, 2020 15:23
@zube zube bot removed the [zube]: Done label Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants