Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #21372 to 7.x: Upgrade Action: make source URI optional #21440

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

michalpristas
Copy link
Contributor

Cherry-pick of PR #21372 to 7.x branch. Original message:

What does this PR do?

This PR makes source URI optional and requires it on snapshot upgrades. Otherwise if it is missing agent uses source URI from elastic-agent configuration.

Making it optional enables us to be prepared for cases when fleet will support snapshot upgrades without a change.

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

)

[Ingest Manager] Upgrade Action: make source URI optional (elastic#21372)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 1, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21440 opened]

  • Start Time: 2020-10-01T06:56:26.771+0000

  • Duration: 36 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 1390
Skipped 4
Total 1394

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good.

@michalpristas michalpristas merged commit 8fe6158 into elastic:7.x Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport enhancement Ingest Management:beta2 Group issues for ingest management beta2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants