-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove nil-zero metrics and linux-exclusive metrics from Metricbeat #21457
Remove nil-zero metrics and linux-exclusive metrics from Metricbeat #21457
Conversation
Pinging @elastic/integrations (Team:Integrations) |
Alright, looks like I need to fix the python tests... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have the broader context to evaluate the migration approach so I hope other reviewers chime in, but taking the business logic as a given, the content of the change looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the part to make sure host.cpu.pct
exists.
@fearful-symmetry I've looked a core logic seems OK to me, but I am not the most familiar with the metric modules. @exekias or @andrewkroh might be good to ping. |
New
New memory document with Agent:
|
…lastic#21457) * refactor metricbeat to remove nil-zero metrics and linux-exclusive metrics * update xpack docs * fix non-linux diskstat builds * fix linux test builds * fix python tests * move windows files for disk performance * properly fix test_drop_fields * try to fix different system test * mage fmt * fix windows filesystem tests * fix platform test * add changelog (cherry picked from commit aed4831)
…e metrics from Metricbeat (#21597) * Remove nil-zero metrics and linux-exclusive metrics from Metricbeat (#21457) * refactor metricbeat to remove nil-zero metrics and linux-exclusive metrics * update xpack docs * fix non-linux diskstat builds * fix linux test builds * fix python tests * move windows files for disk performance * properly fix test_drop_fields * try to fix different system test * mage fmt * fix windows filesystem tests * fix platform test * add changelog (cherry picked from commit aed4831) * fix fields
…ci-build-label-support * upstream/master: (60 commits) Skip publisher flaky tests (elastic#21657) backport: add 7.10 branch (elastic#21635) [CI: Packaging] fix: push ubi8 images too (elastic#21621) Docker build resiliance with a retry (elastic#21587) Fix flaky FSWatch/FSScanner tests (elastic#21625) chore: add versions 7.1x (elastic#21670) [Elastic Agent] Reload fleet.kibana.hosts from policy change (elastic#21599) Fix cyberark/corepas pipeline (elastic#21643) Add openstack ssl provider in add_cloud_metadata (elastic#21590) Add fips_enabled into all aws filesets (elastic#21626) [Filebeat S3] Change log.file.path to be nested object (elastic#21624) [CI] Change notification channel (elastic#21559) Add `add_observer_metadata` `geo.name` to Quickstart (elastic#21501) [E2E Tests] fix: set versions ony for PRs (elastic#21608) Fix badger build in 386 (elastic#21613) docs: Update timestamp.asciidoc (elastic#20395) Remove nil-zero metrics and linux-exclusive metrics from Metricbeat (elastic#21457) [Metricbeat] Use timestamp from CloudWatch for events (elastic#21498) [Filebeat][S3 Input] Add support for FIPS endpoints (elastic#21585) [Ingest Manager] Use new form of fleet API paths (elastic#21478) ...
…012-2.0 * upstream/master: (110 commits) Skip publisher flaky tests (elastic#21657) backport: add 7.10 branch (elastic#21635) [CI: Packaging] fix: push ubi8 images too (elastic#21621) Docker build resiliance with a retry (elastic#21587) Fix flaky FSWatch/FSScanner tests (elastic#21625) chore: add versions 7.1x (elastic#21670) [Elastic Agent] Reload fleet.kibana.hosts from policy change (elastic#21599) Fix cyberark/corepas pipeline (elastic#21643) Add openstack ssl provider in add_cloud_metadata (elastic#21590) Add fips_enabled into all aws filesets (elastic#21626) [Filebeat S3] Change log.file.path to be nested object (elastic#21624) [CI] Change notification channel (elastic#21559) Add `add_observer_metadata` `geo.name` to Quickstart (elastic#21501) [E2E Tests] fix: set versions ony for PRs (elastic#21608) Fix badger build in 386 (elastic#21613) docs: Update timestamp.asciidoc (elastic#20395) Remove nil-zero metrics and linux-exclusive metrics from Metricbeat (elastic#21457) [Metricbeat] Use timestamp from CloudWatch for events (elastic#21498) [Filebeat][S3 Input] Add support for FIPS endpoints (elastic#21585) [Ingest Manager] Use new form of fleet API paths (elastic#21478) ...
What does this PR do?
This PR has two main parts:
0
instead of nothing) for a given metric on a given OS, add some conditional logic so we don't report it.Also note, I'm actively working on this PR, so it might be a tad rough right now, but I want eyes on it.
Where do we go from here?
IsAgent
logic we have to prevent breaking field changes in metricbeat.Open Questions
system
now have their own module inlinux
. After this PR, we'll add these new linux modules to the Linux integration within fleet. From the perspective of metricbeat, we're now reporting identical data in two places: in the default system module, and in new metricsets within the linux integration. Is this the best route? Is there a better way to handle metrics we're trying to relocate?Why is it important?
This is the result of a lot of work between @mukeshelastic and I, with two goals:
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
mage package
to generate a system-specific build object. You can use thePLATFORMS
environment variable to constrain to a given OS/arch pair likelinux/amd64
.cpu
,memory
,diskio
,process
,filesystem
,fsstat
fields haven't changed relative todata.json
memory
andiostat
linux metricsets for all the expected fields.cpu
,memory
,diskio
,process
,filesystem
, andfsstat
metricsets to make sure all the fields reported asIncorrect 0 value?
on the spreadsheet are no longer reported.IsAgent
constraints are working and we're not reporting additional data.