Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #21425 to 7.x: [Elastic Agent] Add upgrade CLI to initiate upgrade of Agent locally #21542

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

blakerouse
Copy link
Contributor

Cherry-pick of PR #21425 to 7.x branch. Original message:

What does this PR do?

Adds a new upgrade CLI command that communicates with the running Elastic Agent to perform self-upgrading. This also allows a local upgrade to a new build using the --source-uri file://${path} command line flag.

Why is it important?

To allow upgrading of the installed Elastic Agent, as well as to help with testing the upgrade process because of the allowed file:// prefix in the --source-uri.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Using a properly installed Elastic Agent with ./elastic-agent install. You can initiate an upgrade:

$ elastic-agent upgrade 8.0.0

The above will fail because there is no pushed 8.0.0, but using the same command and the added --source-uri upgrading can be tested.

$ elastic-agent upgrade 8.0.0 --source-uri file://$PWD/build/distributions

This requires that the branch was build with DEV on so that the *.asc files are not required DEV=true mag package. You can point it to the same installed version but that will result in the following error:

$ elastic-agent upgrade 8.0.0 --source-uri file://$PWD/build/distributions
The upgrade process of Elastic Agent is currently EXPERIMENTAL and should not be used in production
Failed trigger upgrade of daemon: upgrading to same version: /go/src/github.com/elastic/beats/x-pack/elastic-agent/pkg/agent/application/upgrade/upgrade.go[103]: unknown error

Adding a commit and rebuilding will result in a new version that will successfully upgrade.

$ elastic-agent upgrade 8.0.0 --source-uri file://$PWD/build/distributions
The upgrade process of Elastic Agent is currently EXPERIMENTAL and should not be used in production
Upgrade triggered to version 8.0.0, Elastic Agent is currently restarting

Related issues

…lastic#21425)

* Add new upgrade command to initiate a local upgrade of Elastic Agent.

* Update drop path with file:// prefix is defined.

* Add comment.

* Add missing new line.

* Add changelog.

* Prevent upgrading of Agent locally when connected to Fleet.

* Fixes from rebase.

(cherry picked from commit c858dd0)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 5, 2020
@blakerouse blakerouse self-assigned this Oct 5, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21542 opened]

  • Start Time: 2020-10-05T18:53:33.525+0000

  • Duration: 42 min 9 sec

Test stats 🧪

Test Results
Failed 0
Passed 1384
Skipped 4
Total 1388

Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks ok

@blakerouse blakerouse merged commit f3b1b7b into elastic:7.x Oct 6, 2020
@blakerouse blakerouse deleted the backport_21425_7.x branch October 6, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants