-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make logstash/node metricset work for Stack Monitoring without xpack.enabled flag #21545
Make logstash/node metricset work for Stack Monitoring without xpack.enabled flag #21545
Conversation
Pinging @elastic/stack-monitoring (Stack monitoring) |
Pinging @elastic/integrations-services (Team:Services) |
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures> Show only the first 10 test failures
|
Test | Results |
---|---|
Failed | 14 |
Passed | 2699 |
Skipped | 250 |
Total | 2963 |
Genuine test errors
💔 There are test failures but not known flaky tests, most likely a genuine test failure.
- Name:
Build&Test / metricbeat-unitTest / TestEventMapping – stats
- Name:
Build&Test / metricbeat-unitTest / [build failed] – node
- Name:
Build&Test / metricbeat-windows-windows-2019 / TestEventMapping – stats
- Name:
Build&Test / metricbeat-windows-windows-2019 / [build failed] – node
- Name:
Build&Test / metricbeat-goIntegTest / TestXPackEnabled – kibana
- Name:
Build&Test / metricbeat-goIntegTest / TestFetch – stats
- Name:
Build&Test / metricbeat-goIntegTest / TestFetch – logstash
- Name:
Build&Test / metricbeat-goIntegTest / TestFetch/node – logstash
- Name:
Build&Test / metricbeat-pythonIntegTest / test_migration – metricbeat.tests.system.test_base.Test
- Name:
Build&Test / metricbeat-pythonIntegTest / test_template – metricbeat.tests.system.test_base.Test
- Name:
Build&Test / metricbeat-pythonIntegTest / test_xpack – metricbeat.module.kibana.test_kibana.Test
- Name:
Build&Test / metricbeat-pythonIntegTest / test_node – metricbeat.module.logstash.test_logstash.Test
- Name:
Build&Test / x-pack/metricbeat-build / test_migration – x-pack.metricbeat.tests.system.test_xpack_base.Test
- Name:
Build&Test / x-pack/metricbeat-build / test_template – x-pack.metricbeat.tests.system.test_xpack_base.Test
This PR contains the |
Sorry. I'll leave this one until we have finished #21546 until I understand few of the difference between this metricset and |
Sure, what's your question? |
…sh/node_xpack_flag # Conflicts: # metricbeat/module/kibana/stats/stats.go # metricbeat/module/logstash/node/data_xpack.go
This PR is finally merged into #19747 |
Ready to test