Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #21644 to 7.x: Remove dot from file.extension value in Auditbeat FIM #21741

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Cherry-pick #21644 to 7.x: Remove dot from file.extension value in Auditbeat FIM #21741

merged 1 commit into from
Oct 19, 2020

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Oct 13, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #21644 to 7.x branch. Original message:

What does this PR do?

The ECS file.extension field should not include the dot. For example the value should be "png" and not ".png".

Why is it important?

It's important to have all file.extension values conform to the same format declared by ECS.

Checklist

  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@andrewkroh
Remove dot from file.extension value in Auditbeat FIM (elastic#21644)
0e27f0d 
The ECS file.extension field should not include the dot. For example the value should be "png" and not ".png".

Relates elastic/ecs#1016

(cherry picked from commit 500e8b5)
@andrewkroh andrewkroh requested a review from a team as a code owner October 13, 2020 11:15
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 13, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 13, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [andrewkroh commented: run tests]

  • Start Time: 2020-10-15T20:04:25.711+0000

  • Duration: 41 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 487
Skipped 57
Total 544

@andrewkroh
Copy link
Member Author

run tests

@andrewkroh andrewkroh merged commit 708f475 into elastic:7.x Oct 19, 2020
@zube zube bot removed the [zube]: Done label Jan 18, 2021
@andrewkroh andrewkroh deleted the backport_21644_7.x branch January 14, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc-gr marc-gr marc-gr approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewkroh @elasticmachine @marc-gr