Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable TestReceiveEventsAndMetadata/TestSocketCleanup/TestReceiveNewEventsConcurrently in Windows #21750

Merged
merged 4 commits into from
Oct 14, 2020
Merged

disable TestReceiveEventsAndMetadata/TestSocketCleanup/TestReceiveNewEventsConcurrently in Windows #21750

merged 4 commits into from
Oct 14, 2020

Conversation

v1v
Copy link
Member

@v1v v1v commented Oct 13, 2020 •
edited by zube bot
Loading

What does this PR do?

Why is it important?

Use windows-2016 for filebeat

Related issues

@v1v v1v added flaky-test Unstable or unreliable test cases. automation Team:Automation Label for the Observability productivity team windows-2016 Enable builds in the CI for windows-2016 labels Oct 13, 2020
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 13, 2020
@v1v v1v marked this pull request as draft October 13, 2020 13:20
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 13, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21750 updated]

  • Start Time: 2020-10-14T12:19:45.702+0000

  • Duration: 63 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 5780
Skipped 851
Total 6631

@v1v v1v requested review from jsoriano and a team October 13, 2020 15:47
@v1v v1v self-assigned this Oct 13, 2020
@v1v v1v marked this pull request as ready for review October 13, 2020 15:48
@jsoriano
Copy link
Member

But there are two test failures -> #21757

@v1v could you also skip them on Windows in this PR?

Thanks!

@v1v
Copy link
Member Author

v1v commented Oct 14, 2020

@jsoriano see e3084ae, although why it does not fail on windows-2019? Should the skip be only for versions <= windows-2016? If so, how do we do that?

@jsoriano
Copy link
Member

although why it does not fail on windows-2019?

Looking at the test it seems that it fails because it cannot open a unix socket. It seems that this was something recently added to Windows, so it won't work in older versions.

Should the skip be only for versions <= windows-2016? If so, how do we do that?

Maybe the test should try to open a unix socket, and if it cannot, skip the test.

But feel free to skip it by now, and let this as an action point in #21757.

@v1v v1v mentioned this pull request Oct 14, 2020
Closed
jsoriano
jsoriano approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@v1v v1v merged commit 3f57f0e into elastic:master Oct 14, 2020
@v1v v1v changed the title disable TestReceiveEventsAndMetadata in Windows disable TestReceiveEventsAndMetadata/TestSocketCleanup/TestReceiveNewEventsConcurrently in Windows Oct 14, 2020
@v1v v1v deleted the feature/ignore-19641 branch October 14, 2020 13:52
v1v added a commit to v1v/beats that referenced this pull request Oct 14, 2020
@v1v
disable TestReceiveEventsAndMetadata/TestSocketCleanup/TestReceiveNew…
a3228aa 
…EventsConcurrently in Windows (elastic#21750)
@v1v v1v mentioned this pull request Oct 14, 2020
Merged
v1v added a commit to v1v/beats that referenced this pull request Oct 14, 2020
@v1v
disable TestReceiveEventsAndMetadata/TestSocketCleanup/TestReceiveNew…
5b5bedb 
…EventsConcurrently in Windows (elastic#21750)
@v1v v1v mentioned this pull request Oct 14, 2020
Merged
v1v added a commit to v1v/beats that referenced this pull request Oct 14, 2020
@v1v
disable TestReceiveEventsAndMetadata/TestSocketCleanup/TestReceiveNew…
2fee547 
…EventsConcurrently in Windows (elastic#21750)
@v1v v1v mentioned this pull request Oct 14, 2020
Merged
v1v added a commit that referenced this pull request Oct 14, 2020
@v1v
disable TestReceiveEventsAndMetadata/TestSocketCleanup/TestReceiveNew…
76c27aa 
…EventsConcurrently in Windows (#21750) (#21798)
v1v added a commit to v1v/beats that referenced this pull request Oct 14, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/ci-pipeli…
e60b7d6 
…ne-2.0-arm

* upstream/master: (93 commits)
  Fix non-windows fields on system/filesystem (elastic#21758)
  disable TestReceiveEventsAndMetadata/TestSocketCleanup/TestReceiveNewEventsConcurrently in Windows (elastic#21750)
  Use badger code from upstream repository (elastic#21705)
  Disable writes sync in persistent cache (elastic#21754)
  Make API address and Shard ID required in Cloud Foundry settings (elastic#21759)
  [CI] Support skip-ci label (elastic#21377)
  Increase recommended memory when deploying in Cloud foundry (elastic#21755)
  typofix for dns timeout configuration option (elastic#21069)
  chore: create CI artifacts for DEV usage (elastic#21645)
  [Ingest Manager] Atomic installed forgotten changelog elastic#21780
  [Ingest Manager] Agent atomic installer (elastic#21745)
  Add missing configuration annotations (elastic#21736)
  [Filebeat] Add check for context.DeadlineExceeded error (elastic#21732)
  Remove kafka partition ISR from Metricbeat docs (elastic#21709)
  Skip flaky test with oauth2 config in httpjson input (elastic#21749)
  Fix for azure retrieve resource by ids (elastic#21711)
  Update obs app links (elastic#21682)
  fix: update fleet test suite name (elastic#21738)
  Remove dot from file.extension value in Auditbeat FIM (elastic#21644)
  Fix leaks with metadata processors (elastic#16349)
  ...
v1v added a commit that referenced this pull request Oct 14, 2020
@v1v
disable TestReceiveEventsAndMetadata/TestSocketCleanup/TestReceiveNew…
1ed9978 
…EventsConcurrently in Windows (#21750) (#21799)
v1v added a commit that referenced this pull request Oct 14, 2020
@v1v
disable TestReceiveEventsAndMetadata/TestSocketCleanup/TestReceiveNew…
539a4db 
…EventsConcurrently in Windows (#21750) (#21800)
v1v added a commit to v1v/beats that referenced this pull request Oct 15, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-10
1997de1 
* upstream/master: (29 commits)
  [CI] Enable build stage for arm architecture (elastic#21284)
  [BUILD][CI] fetch dependencies with retry (elastic#21614)
  Add proxy metricset (elastic#21751)
  [Filebeat][httpjson] Fix date_cursor validation (elastic#21756)
  Update endpoint-related terminology in Elastic Agent docs (elastic#21458)
  Move s3_daily_storage and s3_request metricsets to use cloudwatch input (elastic#21703)
  [Agent] Remove heartbeat from bundled beats in agent. (elastic#21602)
  [Elastic Agent] Don't perform install until after enroll (elastic#21772)
  [Elastic Agent] Update path from policy change for Kibana connection. (elastic#21804)
  Change cloud.provider from googlecloud to gcp (elastic#21775)
  Fix stress test package list (elastic#21719)
  [Elastic Agent] Remove the service installer scripts from packaging (elastic#21694)
  [CI] Support Windows-2012 in pipeline 2.0 (elastic#21338)
  Fix non-windows fields on system/filesystem (elastic#21758)
  disable TestReceiveEventsAndMetadata/TestSocketCleanup/TestReceiveNewEventsConcurrently in Windows (elastic#21750)
  Use badger code from upstream repository (elastic#21705)
  Disable writes sync in persistent cache (elastic#21754)
  Make API address and Shard ID required in Cloud Foundry settings (elastic#21759)
  [CI] Support skip-ci label (elastic#21377)
  Increase recommended memory when deploying in Cloud foundry (elastic#21755)
  ...
v1v added a commit to v1v/beats that referenced this pull request Oct 15, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-7-64
662166b 
* upstream/master: (216 commits)
  [CI] Enable build stage for arm architecture (elastic#21284)
  [BUILD][CI] fetch dependencies with retry (elastic#21614)
  Add proxy metricset (elastic#21751)
  [Filebeat][httpjson] Fix date_cursor validation (elastic#21756)
  Update endpoint-related terminology in Elastic Agent docs (elastic#21458)
  Move s3_daily_storage and s3_request metricsets to use cloudwatch input (elastic#21703)
  [Agent] Remove heartbeat from bundled beats in agent. (elastic#21602)
  [Elastic Agent] Don't perform install until after enroll (elastic#21772)
  [Elastic Agent] Update path from policy change for Kibana connection. (elastic#21804)
  Change cloud.provider from googlecloud to gcp (elastic#21775)
  Fix stress test package list (elastic#21719)
  [Elastic Agent] Remove the service installer scripts from packaging (elastic#21694)
  [CI] Support Windows-2012 in pipeline 2.0 (elastic#21338)
  Fix non-windows fields on system/filesystem (elastic#21758)
  disable TestReceiveEventsAndMetadata/TestSocketCleanup/TestReceiveNewEventsConcurrently in Windows (elastic#21750)
  Use badger code from upstream repository (elastic#21705)
  Disable writes sync in persistent cache (elastic#21754)
  Make API address and Shard ID required in Cloud Foundry settings (elastic#21759)
  [CI] Support skip-ci label (elastic#21377)
  Increase recommended memory when deploying in Cloud foundry (elastic#21755)
  ...
v1v added a commit to v1v/beats that referenced this pull request Oct 15, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-2008
a21f05c 
* upstream/master: (156 commits)
  [CI] Enable build stage for arm architecture (elastic#21284)
  [BUILD][CI] fetch dependencies with retry (elastic#21614)
  Add proxy metricset (elastic#21751)
  [Filebeat][httpjson] Fix date_cursor validation (elastic#21756)
  Update endpoint-related terminology in Elastic Agent docs (elastic#21458)
  Move s3_daily_storage and s3_request metricsets to use cloudwatch input (elastic#21703)
  [Agent] Remove heartbeat from bundled beats in agent. (elastic#21602)
  [Elastic Agent] Don't perform install until after enroll (elastic#21772)
  [Elastic Agent] Update path from policy change for Kibana connection. (elastic#21804)
  Change cloud.provider from googlecloud to gcp (elastic#21775)
  Fix stress test package list (elastic#21719)
  [Elastic Agent] Remove the service installer scripts from packaging (elastic#21694)
  [CI] Support Windows-2012 in pipeline 2.0 (elastic#21338)
  Fix non-windows fields on system/filesystem (elastic#21758)
  disable TestReceiveEventsAndMetadata/TestSocketCleanup/TestReceiveNewEventsConcurrently in Windows (elastic#21750)
  Use badger code from upstream repository (elastic#21705)
  Disable writes sync in persistent cache (elastic#21754)
  Make API address and Shard ID required in Cloud Foundry settings (elastic#21759)
  [CI] Support skip-ci label (elastic#21377)
  Increase recommended memory when deploying in Cloud foundry (elastic#21755)
  ...
v1v added a commit to v1v/beats that referenced this pull request Oct 15, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-7-32
b359f40 
* upstream/master: (156 commits)
  [CI] Enable build stage for arm architecture (elastic#21284)
  [BUILD][CI] fetch dependencies with retry (elastic#21614)
  Add proxy metricset (elastic#21751)
  [Filebeat][httpjson] Fix date_cursor validation (elastic#21756)
  Update endpoint-related terminology in Elastic Agent docs (elastic#21458)
  Move s3_daily_storage and s3_request metricsets to use cloudwatch input (elastic#21703)
  [Agent] Remove heartbeat from bundled beats in agent. (elastic#21602)
  [Elastic Agent] Don't perform install until after enroll (elastic#21772)
  [Elastic Agent] Update path from policy change for Kibana connection. (elastic#21804)
  Change cloud.provider from googlecloud to gcp (elastic#21775)
  Fix stress test package list (elastic#21719)
  [Elastic Agent] Remove the service installer scripts from packaging (elastic#21694)
  [CI] Support Windows-2012 in pipeline 2.0 (elastic#21338)
  Fix non-windows fields on system/filesystem (elastic#21758)
  disable TestReceiveEventsAndMetadata/TestSocketCleanup/TestReceiveNewEventsConcurrently in Windows (elastic#21750)
  Use badger code from upstream repository (elastic#21705)
  Disable writes sync in persistent cache (elastic#21754)
  Make API address and Shard ID required in Cloud Foundry settings (elastic#21759)
  [CI] Support skip-ci label (elastic#21377)
  Increase recommended memory when deploying in Cloud foundry (elastic#21755)
  ...
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@v1v
disable TestReceiveEventsAndMetadata/TestSocketCleanup/TestReceiveNew…
dffd5e7 
…EventsConcurrently in Windows (elastic#21750) (elastic#21800)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuisathaverat kuisathaverat kuisathaverat approved these changes

@mdelapenya mdelapenya mdelapenya approved these changes

@cachedout cachedout cachedout approved these changes

@jsoriano jsoriano jsoriano approved these changes

Assignees

@v1v v1v

Labels
automation flaky-test Unstable or unreliable test cases. Team:Automation Label for the Observability productivity team windows-2016 Enable builds in the CI for windows-2016
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@v1v @elasticmachine @jsoriano @cachedout @mdelapenya @kuisathaverat