Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #21758 to 7.10: Fix non-windows fields on system/filesystem #21805

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Cherry-pick #21758 to 7.10: Fix non-windows fields on system/filesystem #21805

merged 1 commit into from
Oct 14, 2020

Conversation

fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Oct 14, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #21758 to 7.10 branch. Original message:

What does this PR do?

This swaps out the files and free fields that are reported under under any non-windows OSes. free should be reported on windows, and files should not be reported on windows.

Why is it important?

We need to report the correct fields in Windows.

Checklist

  • My code follows the style guidelines of this project
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  • Pull down PR, build metricbeat on Windows
  • On Windows, make sure filesystem.free is there, and filesystem.files isn't.

@fearful-symmetry
Fix non-windows fields on system/filesystem (elastic#21758)
e79295c 
* fix windows fields on system/filesystem

* add changelog

* fix tests

(cherry picked from commit 4a9b08a)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 14, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21805 opened]

  • Start Time: 2020-10-14T15:04:02.579+0000

  • Duration: 94 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 2237
Skipped 505
Total 2742

@fearful-symmetry fearful-symmetry merged commit eebe220 into elastic:7.10 Oct 14, 2020
@zube zube bot removed the [zube]: Done label Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees
No one assigned
Labels
backport Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fearful-symmetry @elasticmachine @kaiyan-sheng