Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #21775 to 7.x: Change cloud.provider from googlecloud to gcp #21811

Merged
merged 2 commits into from
Oct 14, 2020
Merged

Cherry-pick #21775 to 7.x: Change cloud.provider from googlecloud to gcp #21811

merged 2 commits into from
Oct 14, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Oct 14, 2020

Cherry-pick of PR #21775 to 7.x branch. Original message:

What does this PR do?

This PR is to change cloud.provider value from googlecloud to gcp to match the value from add_cloud_metadata processor.

Also in ECS documentation, gcp is used as an example under cloud.provider field.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@kaiyan-sheng kaiyan-sheng added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Oct 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 14, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Oct 14, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21811 updated]

  • Start Time: 2020-10-14T16:40:36.886+0000

  • Duration: 67 min 42 sec

Test stats 🧪

Test Results
Failed 0
Passed 602
Skipped 48
Total 650

@kaiyan-sheng kaiyan-sheng merged commit fe0649d into elastic:7.x Oct 14, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_21775_7.x branch October 14, 2020 18:22
@zube zube bot removed the [zube]: Done label Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants