Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #21602 to 7.10: [Agent] Remove heartbeat from bundled beats in agent. #21820

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Cherry-pick #21602 to 7.10: [Agent] Remove heartbeat from bundled beats in agent. #21820

merged 1 commit into from
Oct 14, 2020

Conversation

andrewvc
Copy link
Contributor

Cherry-pick of PR #21602 to 7.10 branch. Original message:

This keeps most of the changes in #20488 but un-bundles heartbeat since it's not ready for prime time yet. We may as well keep the work that has been done already, but keep it somewhat out of the way and undocumented / unsupported for now. We will open a separate issue for removing the package.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@andrewvc
[Agent] Remove heartbeat from bundled beats in agent. (elastic#21602)
bf3580a 
This keeps most of the changes in
elastic#20488 but unbundles heartbeat
since it's not ready for prime time yet. We may as well keep the work
that has been done already IMHO.

(cherry picked from commit 39b1db8)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 14, 2020
ph
ph approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tested

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21820 opened]

  • Start Time: 2020-10-14T18:50:39.034+0000

  • Duration: 81 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 16324
Skipped 1365
Total 17689

@andrewvc andrewvc merged commit 81dc892 into elastic:7.10 Oct 14, 2020
@andrewvc andrewvc deleted the backport_21602_7.10 branch October 14, 2020 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ph ph ph approved these changes

Assignees
No one assigned
Labels
backport [zube]: In Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewvc @elasticmachine @ph